chore: Remove unexpected fields in action update payload

[sharat87]

For action update API, client is sending in some fields that the server isn't expecting. As part of tightening what the server accepts in APIs for better security testing, this PR removes these unexpected fields, and sends only what the server knows about, and expects.

/test sanity datasource

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9250048039
Commit: f0f1925
Cypress dashboard url: Click here!

[coderabbitai]

Walkthrough

Walkthrough

The recent updates to ActionAPI.tsx primarily involve code refactoring and cleanup. Several obsolete interfaces have been removed, and there are modifications to existing interfaces. Additionally, an import for the React type has been added. The ActionAPI class method for updating actions has also been refactored for better efficiency and readability.

Changes

Files	Change Summary
app/client/src/api/ActionAPI.tsx	Addition of import type React from "react";, removal of various interfaces, modification in Property interface, changes in multiple interfaces, and refactoring of the ActionAPI class method for updating actions.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant ActionAPI

    Client->>ActionAPI: Update Action Request
    ActionAPI-->>Client: Action Update Response

Loading

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a68ba88 and f0f1925.

Files selected for processing (1)

• app/client/src/api/ActionAPI.tsx (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/client/src/api/ActionAPI.tsx

Warning

Review ran into problems

Problems (1)

• Git: Failed to clone repository. Please contact CodeRabbit support.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (3)

app/client/src/api/ActionAPI.tsx (3)

Line range hint 178-178: Use template literals for string concatenation.

Using template literals can improve readability and maintainability of the code. Replace string concatenation with template literals.

- return API.put(ActionAPI.url + "/refactor", updateActionNameRequest);
+ return API.put(`${ActionAPI.url}/refactor`, updateActionNameRequest);

- return API.post(ActionAPI.url + "/execute", executeAction, undefined, {
+ return API.post(`${ActionAPI.url}/execute`, executeAction, undefined, {

- return API.delete(`${ActionAPI.url}/${id}`);
+ return API.delete(`${ActionAPI.url}/${id}`);

- return API.put(ActionAPI.url + "/move", moveRequest, undefined, {
+ return API.put(`${ActionAPI.url}/move`, moveRequest, undefined, {

Also applies to: 188-188, 214-214, 223-223

---

Line range hint 206-209: Clarify usage of this in static context.

Using this in static methods can be confusing as it does not refer to an instance of the class but to the class itself. Consider using the class name ActionAPI instead of this for clarity.

- return this.executeApiCall(executeAction, timeout);
+ return ActionAPI.executeApiCall(executeAction, timeout);

---

Line range hint 125-227: Consider refactoring the class to avoid only static members.

Classes that contain only static members can sometimes be better represented as a module with exported functions, especially in JavaScript/TypeScript. This can improve modularity and testability of the code.