chore: Remove unused eventData

[sharat87]

For action creation, client sends this in eventData field of the request body:

But the class defined for eventData is this:

Clearly isn't used, or working.

/test sanity datasource

⚠️ Note that eventData is actually used in the analytics data sent by client, and that's not being removed here. We're only removing the unused server-side support here.

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9242015567
Commit: 30e8f45
Cypress dashboard url: Click here!

[coderabbitai]

Walkthrough

Walkthrough

The recent changes involve modifying the handling of eventData within the ActionAPI class on the client side and removing AnalyticsInfo from the ActionCE_DTO class on the server side. Additionally, a test method related to analytics data persistence was removed from the ActionServiceCE_Test class.

Changes

Files	Change Summary
app/client/src/api/ActionAPI.tsx	Updated createAction method to set eventData to undefined in apiConfig.
app/server/.../com/appsmith/external/models/ce/ActionCE_DTO.java	Removed AnalyticsInfo field and related logic from ActionCE_DTO class.
app/server/.../appsmith-server/src/test/java/com/appsmith/server/services/ce/ActionServiceCE_Test.java	Removed test method createCopyActionWithAnalyticsData_validateAnalyticsDataPersistsInResponse().

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant Server
    Client->>Server: createAction({ ...apiConfig, eventData: undefined })
    Note right of Server: Server processes request without eventData
    Server-->>Client: Response

Loading

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

• Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
• Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
• Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

• Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
• Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
• High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
• Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 55ae859 and 30e8f45.

Files selected for processing (3)

• app/client/src/api/ActionAPI.tsx (1 hunks)
• app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/ce/ActionCE_DTO.java (3 hunks)
• app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ActionServiceCE_Test.java (2 hunks)

Files skipped from review due to trivial changes (2)

• app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/ce/ActionCE_DTO.java
• app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ActionServiceCE_Test.java

Additional Context Used

Biome (9)

app/client/src/api/ActionAPI.tsx (9)

88-88: Unexpected any. Specify a different type.

---

158-258: Avoid classes that contain only static members.

---

198-198: Avoid the delete operator which can impact performance.

---

209-209: Template literals are preferred over string concatenation.

---

219-219: Template literals are preferred over string concatenation.

---

237-237: Using this in a static context can be confusing.

---

240-240: Using this in a static context can be confusing.

---

245-245: Template literals are preferred over string concatenation.

---

254-254: Template literals are preferred over string concatenation.

Additional comments not posted (1)

app/client/src/api/ActionAPI.tsx (1)

168-168: Set eventData to undefined to ensure it's not used.

This change aligns with the PR's objective to remove unused eventData. It effectively prevents the client from sending this data by setting it to undefined in the request body.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (5)

app/client/src/api/ActionAPI.tsx (5)

Line range hint 158-258: Consider refactoring the class into a module.

Since ActionAPI only contains static methods, converting it into a module with exported functions could simplify the structure and reduce overhead. Here's a proposed change:

// Before
class ActionAPI {
  static async createAction(...) { ... }
  static async fetchActions(...) { ... }
  // other static methods
}

// After
export const createAction = async (...) => { ... };
export const fetchActions = async (...) => { ... };
// other exported functions

---

Line range hint 198-198: Avoid using the delete operator.

Using the delete operator can lead to performance deoptimizations. Consider using object destructuring to omit properties without modifying the original object:

const { name, ...actionWithoutName } = apiConfig;
return API.put(`${ActionAPI.url}/${actionWithoutName.id}`, actionWithoutName, undefined, {
  cancelToken: ActionAPI.apiUpdateCancelTokenSource.token,
});

---

Line range hint 209-209: Use template literals instead of string concatenation.

Replace string concatenation with template literals for better readability and maintainability:

- return API.put(ActionAPI.url + "/refactor", updateActionNameRequest);
+ return API.put(`${ActionAPI.url}/refactor`, updateActionNameRequest);

- return API.post(ActionAPI.url + "/execute", executeAction, undefined, {
+ return API.post(`${ActionAPI.url}/execute`, executeAction, undefined, {

Also applies to: 219-219, 245-245, 254-254

---

Line range hint 237-237: Avoid using this in static methods.

Replace this with ActionAPI in static methods to clarify that these methods are part of the class and not instance methods:

- return this.executeApiCall(executeAction, timeout);
+ return ActionAPI.executeApiCall(executeAction, timeout);

Also applies to: 240-240

---

Line range hint 88-88: Specify a more precise type instead of any.

The use of any can lead to potential type safety issues. If possible, replace any with a more specific type that describes the structure of dataTypes:

dataTypes: Record<string, unknown>[]; // or another appropriate type