chore: remove commented code from @tag.JS specs

[rishabhrathod01]

Description

Remove commented code for JS related spec

Automation

/ok-to-test tags="@tag.JS"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8920272253
Commit: 8a85334
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Improved test cases for navigation, API interactions, and Oracle datasource handling.
  • Streamlined test scripts by removing redundant code, comments, and unnecessary imports.
  • Simplified handling of JavaScript content and confirmation dialogs in the JSEditor class.

[coderabbitai]

Walkthrough

Walkthrough

The changes in this update aim to enhance the test suite by adding new test cases for error handling and navigation scenarios, alongside code cleanup and improved error handling. These modifications seek to improve test coverage and code quality in the client-side testing framework.

Changes

Files	Change Summary
.../NavigateTo_spec.ts	Added test cases for error handling with invalid URLs and verifying navigation. New imports for PageList added.
.../JSOnLoad2_Spec.ts, .../JsOnLoad3_Spec.ts, .../OnLoadActions_Spec.ts	Removed unused imports, variables, and cleaned up commented-out code.
.../Oracle_Spec.ts	Added a new import and method for handling confirmation dialogs.
.../JSEditor.ts	Removed obsolete methods, updated JavaScript content handling, and simplified assertions.

Possibly related issues

• [Task]: Fix cypress test suite failures caused by PR #29794 #30378: The changes in this PR, particularly the cleanup and addition of new test cases, could address failures in the Cypress test suite mentioned in the issue.
• Cleanup activities #30105: The cleanup activities in the PR, such as removing deprecated code and updating documentation, align with the objectives of this issue.
• [Task]: Remove dead code of welcome tour #30332: Although this PR does not directly remove code related to the welcome tour, the general theme of cleaning and updating code is similar.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0603621 and 8a85334.

Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/client/cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.