Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove git release feature flags #30962

Merged
merged 32 commits into from
Feb 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
4eaac2e
remove git_connect_v2 feature flag from code
brayn003 Feb 7, 2024
5e7bc26
removing connect v2 frature flag from tests
brayn003 Feb 7, 2024
6802916
lint fixes for test cases
brayn003 Feb 7, 2024
2d10b5a
fixing build issues
brayn003 Feb 7, 2024
429f952
removing release_git_status_lite_enabled
brayn003 Feb 7, 2024
49b3e1c
adding logic to clear branch protection after connecting to git
brayn003 Feb 7, 2024
a6c5edd
adding lint fixes
brayn003 Feb 7, 2024
e0df642
fixed DisconnectGit_spec
brayn003 Feb 7, 2024
7763f39
lint fixes
brayn003 Feb 7, 2024
eb791f5
removed regenerate SSH key test cases
brayn003 Feb 7, 2024
56fad04
fixing issue with GitwithCustomJSLibrary_spec
brayn003 Feb 7, 2024
699fde7
fixing Deploy_spec
brayn003 Feb 7, 2024
17a7c7e
removing LearnMore_Spec
brayn003 Feb 7, 2024
8d1d092
fixing GitImport_spec
brayn003 Feb 7, 2024
11a9b39
fixed ImportEmptyRepo_spec
brayn003 Feb 7, 2024
5b12b9a
removed Connection_spec
brayn003 Feb 7, 2024
0a9d0f9
fixing RepoLimitExceededErrorModal_spec
brayn003 Feb 7, 2024
c4c4352
lint fixes
brayn003 Feb 7, 2024
4c81652
fixing GitBranchProtect_spec.ts
brayn003 Feb 7, 2024
8297c70
fixing preconnect_spec
brayn003 Feb 7, 2024
36f8120
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/re…
brayn003 Feb 7, 2024
b623127
putting steps inside callback
brayn003 Feb 7, 2024
d8b1c48
fixing issue with gitbugs
brayn003 Feb 8, 2024
9a3e3e8
lint fixes
brayn003 Feb 8, 2024
dc72180
removing skip
brayn003 Feb 8, 2024
d94cd55
removing v2 from variable name
brayn003 Feb 8, 2024
44b4970
remove wait
brayn003 Feb 8, 2024
1f9246e
adding wait till ele disappear
brayn003 Feb 8, 2024
4f938a2
fix: remove commented code
brayn003 Feb 8, 2024
68e1d08
fix: adding more intercepts
brayn003 Feb 8, 2024
4a20537
adding dynamic api based wait
brayn003 Feb 8, 2024
c68f049
lint fixes
brayn003 Feb 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,12 @@ describe("Git import flow ", { tags: ["@tag.Git"] }, function () {
it("2. Import the previous app connected to Git and reconnect Postgres, MySQL and Mongo db ", () => {
homePage.NavigateToHome();
cy.createWorkspace();
let newWorkspaceName;
cy.wait("@createWorkspace").then((interception) => {
const newWorkspaceName = interception.response.body.data.name;
newWorkspaceName = interception.response.body.data.name;
cy.CreateAppForWorkspace(newWorkspaceName, "gitImport");
});
cy.get(homePageLocators.homeIcon).click();
agHelper.GetNClick(homePageLocators.createNew, 0);
cy.get(homePageLocators.workspaceImportAppOption).click({ force: true });
cy.get(".t--import-json-card").next().click();
cy.importAppFromGit(repoName);
gitSync.ImportAppFromGit(newWorkspaceName, repoName);
cy.wait(5000);
cy.get(reconnectDatasourceModal.Modal).should("be.visible");
cy.ReconnectDatasource("TEDPostgres");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,19 @@ describe("Git import empty repository", { tags: ["@tag.Git"] }, function () {
});

it("1. Bug #12749 Git Import - Empty Repo NullPointerException", () => {
cy.get(homePage.homeIcon).click();
_.agHelper.GetNClick(homePage.createNew, 0);
cy.get(homePage.workspaceImportAppOption).click({ force: true });
cy.get(".t--import-json-card").next().click();
cy.generateUUID().then((uid) => {
repoName = uid;
//cy.createTestGithubRepo(repoName);
_.gitSync.CreateTestGiteaRepo(repoName);
cy.importAppFromGit(repoName, true, failureMessage);
_.gitSync.ImportAppFromGit(undefined, repoName, false);
cy.wait("@importFromGit").then((interception) => {
const status = interception.response.body.responseMeta.status;
const message = interception.response.body.responseMeta.error.message;
expect(status).to.be.gte(400);
expect(message).to.contain(failureMessage);
cy.get(gitSyncLocators.closeGitSyncModal).click();
});
});
cy.get(gitSyncLocators.closeGitSyncModal).click();
});
after(() => {
_.gitSync.DeleteTestGithubRepo(repoName);
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ describe("Git sync modal: deploy tab", { tags: ["@tag.Git"] }, function () {
// The deploy preview Link should be displayed only after the first commit done
cy.get(gitSyncLocators.bottomBarCommitButton).click();

// comment text input should not empty
cy.get(gitSyncLocators.commitCommentInput)
.should("be.disabled")
.and("not.be.empty");
cy.get(gitSyncLocators.commitCommentInput).should("be.disabled");
cy.get(gitSyncLocators.commitButton).should("be.disabled");
cy.get(gitSyncLocators.closeGitSyncModal).click();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,20 @@ describe("Git disconnect modal:", { tags: ["@tag.Git"] }, function () {
const newWorkspaceName = interception.response.body.data.name;
cy.CreateAppForWorkspace(newWorkspaceName, newWorkspaceName);
});
cy.generateUUID().then((uid) => {
repoName = uid;
_.gitSync.CreateTestGiteaRepo(repoName);
});
});

it("1. should be opened with proper components", function () {
_.gitSync.AuthorizeKeyToGitea(repoName);
cy.get(gitSyncLocators.bottomBarCommitButton).click();
cy.get("[data-testid=t--tab-GIT_CONNECTION]").click();
cy.generateUUID().then((uid) => {
_.gitSync.CreateNConnectToGit(uid);
cy.get("@gitRepoName").then((repName) => {
repoName = repName;
});
});
cy.get(_.gitSync._bottomSettingsBtn).click();
cy.get(_.gitSync._settingsTabGeneral).click();
// after clicked disconnect on connection modal,
// it should be closed and disconnect modal should be opened
cy.get(gitSyncLocators.disconnectIcon).click();
cy.get(_.gitSync._disconnectGitBtn).click();
cy.get(gitSyncLocators.gitSyncModal).should("not.exist");
cy.get(gitSyncLocators.disconnectGitModal).should("exist");

Expand Down Expand Up @@ -60,12 +61,12 @@ describe("Git disconnect modal:", { tags: ["@tag.Git"] }, function () {
});

it("2. should have disconnect repo button", function () {
cy.get(gitSyncLocators.bottomBarCommitButton).click();
cy.get("[data-testid=t--tab-GIT_CONNECTION]").click();
cy.get(_.gitSync._bottomSettingsBtn).click();
cy.get(_.gitSync._settingsTabGeneral).click();

// after clicked disconnect on connection modal,
// it should be closed and disconnect modal should be opened
cy.get(gitSyncLocators.disconnectIcon).click();
cy.get(_.gitSync._disconnectGitBtn).click();
cy.get(gitSyncLocators.disconnectButton).should("be.disabled");

cy.get(gitSyncLocators.disconnectAppNameInput).type(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,14 @@ describe("Git Branch Protection", { tags: ["@tag.Git"] }, function () {
const appName = "GitBranchProtect-2" + uid;
_.homePage.CreateNewWorkspace(wsName, true);
_.homePage.CreateAppInWorkspace(wsName, appName);
featureFlagIntercept({
release_git_connect_v2_enabled: true,
});
cy.wait(1000);

cy.intercept({
method: "POST",
url: /\/api\/v1\/git\/branch\/app\/.*\/protected/,
}).as("gitProtectApi");

_.gitSync.CreateNConnectToGitV2();
_.gitSync.CreateNConnectToGit("repoprotect", true, true, false);
cy.get("@gitRepoName").then((repName) => {
repoName = repName;
cy.wait("@gitProtectApi").then((res1) => {
Expand Down
Loading
Loading