chore: remove git release feature flags #30962

brayn003 · 2024-02-07T09:45:43Z

Description

Removes git related feature flags

release_git_connct_v2_enabled
release_git_status_lite_enabled

PR fixes following issue(s)

Fixes #30961 and #30954

Media

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

Manual
JUnit
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features
- Enhanced Git synchronization features including better handling of workspace creation, DSL additions, and branch protection settings.
Refactor
- Updated Git connection methods and deployment processes for improved efficiency and reliability.
- Introduced new variables and methods for more precise control over Git settings and operations.
Tests
- Added and refactored Cypress end-to-end tests to validate new Git functionalities and synchronization processes.
Style
- Updated components to include data-testId attributes for improved testability.

brayn003 · 2024-02-07T09:53:39Z

/ok-to-test tags="@tag.All"

github-actions · 2024-02-07T09:54:04Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-02-07T09:54:05Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7812931313.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2024-02-07T10:45:22Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7812931313.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/EchoApiCMS_spec.js
cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts
cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
cypress/e2e/Regression/ClientSide/ExplorerTests/JSEditorContextMenu_Spec.ts
cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
cypress/e2e/Regression/ClientSide/Git/GitImport/ImportEmptyRepo_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/Connection_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/GitBugs_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/LearnMore_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/MergeViaRemote_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/PreconnectionAppNameDeployMenu_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/RegenerateSSHKey_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

brayn003 · 2024-02-07T12:56:55Z

/ok-to-test tags="@tag.All"

github-actions · 2024-02-07T12:57:19Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-02-07T12:57:20Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7815136072.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitBugs_spec.js

app/client/cypress/support/Pages/GitSync.ts

brayn003 · 2024-02-08T11:02:37Z

/ok-to-test tags="@tag.All"

github-actions · 2024-02-08T11:03:00Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-02-08T11:03:01Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7828601472.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2024-02-08T11:52:32Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7828601472.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/GitBugs_spec.js
cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js

To know the list of identified flaky tests - Refer here

brayn003 · 2024-02-08T12:59:51Z

/ok-to-test tags="@tag.All"

github-actions · 2024-02-08T13:00:14Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-02-08T13:00:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7830000154.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2024-02-08T13:10:21Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7830000154.
Commit: ``.
Cypress dashboard url: Click here!
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

brayn003 · 2024-02-08T13:12:28Z

/ok-to-test tags="@tag.All"

github-actions · 2024-02-08T13:12:53Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-02-08T13:12:54Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7830170850.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

app/client/cypress/support/Pages/GitSync.ts

github-actions · 2024-02-08T14:02:39Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7830170850.
Commit: ``.
Cypress dashboard url: Click here!
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

github-actions · 2024-02-08T14:20:40Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7830170850.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/RegenerateSSHKey_spec.js

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/LearnMore_spec.ts

## Description Removes git related feature flags - `release_git_connct_v2_enabled` - `release_git_status_lite_enabled` #### PR fixes following issue(s) Fixes #30961 #### Media #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed  ## Summary by CodeRabbit - **New Features** - Enhanced Git synchronization features including better handling of workspace creation, DSL additions, and branch protection settings. - **Refactor** - Updated Git connection methods and deployment processes for improved efficiency and reliability. - Introduced new variables and methods for more precise control over Git settings and operations. - **Tests** - Added and refactored Cypress end-to-end tests to validate new Git functionalities and synchronization processes. - **Style** - Updated components to include `data-testId` attributes for improved testability.

brayn003 added 3 commits February 7, 2024 15:04

remove git_connect_v2 feature flag from code

4eaac2e

removing connect v2 frature flag from tests

5e7bc26

lint fixes for test cases

6802916

github-actions bot added Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Feb 7, 2024

fixing build issues

2d10b5a

appsmithorg deleted a comment from github-actions bot Feb 7, 2024

removing release_git_status_lite_enabled

429f952

brayn003 added 4 commits February 7, 2024 17:25

adding logic to clear branch protection after connecting to git

49b3e1c

adding lint fixes

a6c5edd

fixed DisconnectGit_spec

e0df642

lint fixes

7763f39

brayn003 added 3 commits February 7, 2024 18:30

removed regenerate SSH key test cases

eb791f5

fixing issue with GitwithCustomJSLibrary_spec

56fad04

fixing Deploy_spec

699fde7

This comment was marked as outdated.

Sign in to view

brayn003 added 2 commits February 7, 2024 20:05

removing LearnMore_Spec

17a7c7e

fixing GitImport_spec

8d1d092

removing skip

dc72180

brayn003 dismissed AmanAgarwal041’s stale review via dc72180 February 8, 2024 09:44

brayn003 added 2 commits February 8, 2024 16:01

removing v2 from variable name

d94cd55

remove wait

44b4970

coderabbitai bot reviewed Feb 8, 2024

View reviewed changes

brayn003 added 2 commits February 8, 2024 16:25

adding wait till ele disappear

1f9246e

fix: remove commented code

4f938a2

brayn003 added 2 commits February 8, 2024 17:59

fix: adding more intercepts

68e1d08

adding dynamic api based wait

4a20537

lint fixes

c68f049

coderabbitai bot reviewed Feb 8, 2024

View reviewed changes

app/client/cypress/support/Pages/GitSync.ts Show resolved Hide resolved

app/client/cypress/support/Pages/GitSync.ts Show resolved Hide resolved

app/client/cypress/support/Pages/GitSync.ts Show resolved Hide resolved

Aishwarya-U-R reviewed Feb 8, 2024

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/RegenerateSSHKey_spec.js Show resolved Hide resolved

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/LearnMore_spec.ts Show resolved Hide resolved

Parthvi12 approved these changes Feb 8, 2024

View reviewed changes

trishaanand merged commit 5c74768 into release Feb 9, 2024
18 checks passed

trishaanand deleted the fix/remove-git-feature-flags branch February 9, 2024 04:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove git release feature flags #30962

chore: remove git release feature flags #30962

brayn003 commented Feb 7, 2024 •

edited

Loading

brayn003 commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

brayn003 commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

This comment was marked as outdated.

brayn003 commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

brayn003 commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

brayn003 commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

chore: remove git release feature flags #30962

chore: remove git release feature flags #30962

Conversation

brayn003 commented Feb 7, 2024 • edited Loading

Description

PR fixes following issue(s)

Media

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Summary by CodeRabbit

brayn003 commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

brayn003 commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

This comment was marked as outdated.

brayn003 commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

brayn003 commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

brayn003 commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

brayn003 commented Feb 7, 2024 •

edited

Loading