Read language version from installation report #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the diagnose report, in the extension installation report section, the wrong language version field was read. It was using the one from the "host" section, which is generated upon execution of the diagnose report. We want to display the field from the installation report, because that may differ, and if it does, point to a different installation machine than the one the app runs on. This could cause problems and we want to highlight those differences. This does affect the report sent to AppSignal.com. Only the report displayed in the terminal.
tombruijn
force-pushed
the
diagnose-fixes
branch
from
0f751c4 to
17a05ef
Compare
2 tasks
luismiramirez
approved these changes
Oct 6, 2021
jeffkreeftmeijer
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the diagnose report, in the extension installation report section,
the wrong language version field was read. It was using the one from the
"host" section, which is generated upon execution of the diagnose
report.
We want to display the field from the installation report, because that
may differ, and if it does, point to a different installation machine
than the one the app runs on. This could cause problems and we want to
highlight those differences.
This does affect the report sent to AppSignal.com. Only the report
displayed in the terminal.