Read language version from installation report (#452)

In the diagnose report, in the extension installation report section, the wrong language version field was read. It was using the one from the "host" section, which is generated upon execution of the diagnose report. We want to display the field from the installation report, because that may differ, and if it does, point to a different installation machine than the one the app runs on. This could cause problems and we want to highlight those differences. This does affect the report sent to AppSignal.com. Only the report displayed in the terminal.
appsignal · Oct 7, 2021 · 42edcc0 · 42edcc0
1 parent d24ccf4
commit 42edcc0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/nodejs/.changesets/show-correct-language-version-in-diagnose.md b/packages/nodejs/.changesets/show-correct-language-version-in-diagnose.md
@@ -0,0 +1,5 @@
+---
+bump: "patch"
+---
+
+Show correct language version in diagnose's extension installation section. It did not show the language version used during install, but the current one used to run the diagnose tool.
diff --git a/packages/nodejs/src/cli/diagnose.ts b/packages/nodejs/src/cli/diagnose.ts
@@ -35,7 +35,9 @@ export class Diagnose {
     console.log(`  Installation result`)
     console.log(`    Status: success`)
     console.log(`  Language details`)
-    console.log(`    Node.js version: ${data["host"]["language_version"]}`)
+    console.log(
+      `    Node.js version: ${data["installation"]["language"]["version"]}`
+    )
     console.log(`  Download details`)
     console.log(
       `    Download URL: ${data["installation"]["download"]["download_url"]}`

diff --git a/test/integration/diagnose b/test/integration/diagnose
+1 −0		.gitignore
+3 −2		bin/test
+8 −0		spec/diagnose_spec.rb