Fix broken KEEP_TRUSTED_CONFIDENTIAL_CLIENT_TOKENS feature + refactor - #477
Merged
OmarIthawi merged 3 commits intoNov 12, 2019
Merged
Conversation
OmarIthawi
requested review from
iamjazzar,
johnbaldwin,
melvinsoft and
thraxil
November 11, 2019 16:12
OmarIthawi
force-pushed
the
omar/latest-version-copy-final3
branch
from
November 11, 2019 17:08
4070846 to
27778ba
Compare
OmarIthawi
force-pushed
the
omar/latest-version-copy-final3
branch
from
November 11, 2019 17:16
27778ba to
9add5a0
Compare
thraxil
approved these changes
Nov 12, 2019
thraxil
left a comment
thraxil
left a comment
There was a problem hiding this comment.
@OmarIthawi I added a commit here (hope you don't mind) that runs the specific test on TravisCI.
Author
|
No way!! Didn't know we could do that! Thank you so much @thraxil! |
|
@OmarIthawi Thanks you so much for fixing this! And Anders for the contribution as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
“The simplest things are the hardest to understand.”
― Kevin Wilson, The Family Fang
The
notwas incorrect and stale, it's been the case since #429Please, run the tests before approving this pull request:
This is the fourth pull request after the following: #398, #416 and #429 so I've got to get right this time, right?