Really set KEEP_TRUSTED_CONFIDENTIAL_CLIENT_TOKENS to a sane default - #429
Merged
Merged
Conversation
OmarIthawi
requested review from
amirtds,
bryanlandia,
iamjazzar,
johnbaldwin and
thraxil
July 18, 2019 08:37
thraxil
approved these changes
Jul 18, 2019
johnbaldwin
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a mistake by setting the default variable to an unsafe default in #416. This PR fixes it by making the feature revert to the Open edX default behaviour:
Reviewers
Please checkout this pull request as well as (https://github.com/appsembler/edx-configs/pull/644) and review it critically for proper feature name and Boolean values.
Background
Please checkout this upstream pull request for more info (https://github.com/edx/edx-platform/pull/20836). Also the Trello Card 👇.