Fix Internet Explorer JS error on course outline - #441
Merged
grozdanowski merged 5 commits intoAug 15, 2019
Conversation
Merge appsembler/tahoe/develop into appsembler/tahoe/master
Merge appsembler/tahoe/develop into appsembler/tahoe/master
Merge develop into master
Tahoe: Merge `develop` into `master`
johnbaldwin
self-requested a review
August 12, 2019 16:22
|
@grozdanowski Do we want to merge this into Aside from the target branch, I say we merge this polyfill and verify it fixes the issue |
Author
|
Agh sorry, I just wanted to get this to production - this heat wave melts my brain. We can go and merge whenever you guys feel would be wiser. It's not that this is a super duper urgent "by tomorrow" fix. |
|
@melvinsoft What say you? Should we change the merge target to |
melvinsoft
approved these changes
Aug 15, 2019
melvinsoft
suggested changes
Aug 15, 2019
melvinsoft
left a comment
melvinsoft
left a comment
There was a problem hiding this comment.
I just realized we need to merge it in develop first, now master.
grozdanowski
changed the base branch from
appsembler/tahoe/master
to
appsembler/tahoe/develop
August 15, 2019 13:18
melvinsoft
approved these changes
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Students are unable to expand any topics in the Course page using IE 11.
Reason
Internet Explorer is something that no one should be using, since it is a lame excuse for a web browser. Essentially it doesn't follow modern JS standards. This is usually resolved using babel polyfills, however Hawthorn has an issue where it uses out dated polyfills that don't address the issue with IE where it doesn't seem to understand that
Arraycan have afrommethod. Well, it is how it is. Stupid and bad.Solution
With help of George Babey from edX I have added the polyfill that helps in this issue manually. Tested it out with IE and it works.
There was much rejoicing. People were cheering. Proud mothers crying.