Tahoe: Merge develop into master - #428
Merged
Merged
Conversation
* Added user filtering to enrollment api test * Updated course enrollment filter to support user filtering * Added user index viewset * Added UserIndexSerializer * Updated v1.urls to include user index viewset * Added unit test for UserIndexViewSet
Author
OmarIthawi
approved these changes
Jul 17, 2019
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Same as #427 that I already approved.
It would be great if @AhmedAljazzar and/or @thraxil can take a quick look even if it's just for awareness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets #427 pushed to production. I spot tested it on staging today with both the user list and user detail views