Fixed milestone issues on Ficus - #216
Merged
Merged
Conversation
Merging Appsembler/ficus/develop to Appsembler/ficus/master
ficus/develop update ficus/master
Added capability to define settings.APPSEMBLER_REPORTING dict if APPSEMBLER_FEATURES has 'ENABLE_APPSEMBLER_REPORTING' to true
…embler-reporting Enable appsembler reporting settings
…eature/appsembler-reporting Revert "Enable appsembler reporting settings"
merge appsembler/ficus/develop to appsembler/ficus/master branch
Merge appsembler/ficus/develop to appsembler/ficus/master branch
merge from Appsembler/ficus/develop - Taxoman updates and small dashboard cert listing change
|
Can one of the admins verify this patch? |
Author
|
@thraxil are you a chat bot? 0-minute difference between the PR and your comment 😱 |
|
@thraxil which admins do you mean? Github admins?
|
|
Yeah, sorry. I'm pretty sure that came from jenkins (I've been working on getting it set up to build PRs). I don't exactly know what that message refers to though. |
Author
tkeemon
approved these changes
Mar 14, 2018
tkeemon
left a comment
tkeemon
left a comment
There was a problem hiding this comment.
Changes look good to me. It's kind of surprising that the remove_prerequisite_course method existed, but was never used anywhere.
Anyway, I think you're good to merge this.
Author
|
@melvinsoft time to get this merged in AMC so customers can live happily ever after. |
In settings_handler and any_unfulfilled_milestones (for mobile APIs)
OmarIthawi
force-pushed
the
omar/enrollment-prereq
branch
from
March 15, 2018 15:08
3754946 to
069ae34
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from edX upstream (https://github.com/edx/edx-platform/pull/14758 and https://github.com/edx/edx-platform/pull/15623) to solve an issue with course prerequisites (check Trello card).
Note: I'm a co-author of the original PR, despite what git thinks 😄. So, I've already tested it on both Dogwood and Open edX
master(at the time).TODO