Merge appsembler/ficus/develop to appsembler/ficus/master branch - #194
Merged
Conversation
Courses API copycat with search via `edx-search`
OmarIthawi
changed the title
Author
…ack-obey-discovery-settings don't automatically enable courseware discovery for devstack
Author
|
@bryanlandia @amirtds @tkeemon could you please take a look? |
melvinsoft
suggested changes
Jan 8, 2018
There was a problem hiding this comment.
@OmarIthawi This is great! just a minor change, everything else looks good to me.
|
|
||
|
|
||
| # override devstack.py automatic enabling of courseware discovery | ||
| FEATURES['ENABLE_COURSE_DISCOVERY'] = ENV_TOKENS.get('TPA_CLEAN_USERNAMES_KEEP_DOMAIN_PART', False) |
There was a problem hiding this comment.
I think you calling a wrong setting here: TPA_CLEAN_USERNAMES_KEEP_DOMAIN_PART
There was a problem hiding this comment.
@OmarIthawi - Yes, this doesn't look right. Looks like that was my commit—not sure how that got so wrong... Should be
FEATURES['ENABLE_COURSE_DISCOVERY'] = ENV_TOKENS['FEATURES'].get('ENABLE_COURSE_DISCOVERY', False)
This is overriding a line in devstack.py which overrides the original FEATURE definition to always turns on course discovery.
Author
|
Same issue, @bryanlandia could you please check this out?
…On Jan 8, 2018 5:54 PM, "Maximiliano Fernandez" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@OmarIthawi <https://github.com/omarithawi> just a minor change,
everything else looks good to me.
------------------------------
In lms/envs/devstack_appsembler.py
<#194 (comment)>
:
> @@ -122,3 +122,5 @@
pass
+# override devstack.py automatic enabling of courseware discovery
+FEATURES['ENABLE_COURSE_DISCOVERY'] = ENV_TOKENS.get('TPA_CLEAN_USERNAMES_KEEP_DOMAIN_PART', False)
I think you calling a wrong setting here: TPA_CLEAN_USERNAMES_KEEP_
DOMAIN_PART
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#194 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnYJHg-E-_HLRjCDopnTfq_e_115943ks5tIjougaJpZM4RRWGZ>
.
|
…ack-obey-discovery-settings-rework (Fix) don't automatically enable courseware discovery for devstack
Author
|
@melvinsoft We've addressed the issue. I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly to get the #184 released to ASU staging and production. The API has been deployed for a while. I've also created a PR (https://github.com/appsembler/edx-configs/pull/226) to get the ASU Staging back to
appsembler/ficus/master.