don't automatically enable courseware discovery for devstack - #191
Merged
bryanlandia merged 1 commit intoJan 3, 2018
Conversation
bryanlandia
deleted the
appsembler/ficus/hotfix/devstack-obey-discovery-settings
branch
January 3, 2018 20:54
|
@bryanlandia This is probably too late to take a look at. Can't we use it's own variable? Instead of offering a puzzling behavior? |
Author
|
Ah, I see your comments here now @OmarIthawi . Sorry I overlooked them. Yes, it was not only puzzling, but wrong! I added a new PR with a fix #198 |
OmarIthawi
pushed a commit
that referenced
this pull request
Aug 18, 2020
Fix xss while rendering file-upload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devstack enables a bunch of features by default. Obey env_token for
enable_course_discovery.