Skip to content

Fix: cannot import tahoe-sites, not ready yet - #1248

Merged
shadinaif merged 1 commit into
mainfrom
shadinaif/fix-tahoe-sites-cannot-import
Sep 12, 2022
Merged

Fix: cannot import tahoe-sites, not ready yet#1248
shadinaif merged 1 commit into
mainfrom
shadinaif/fix-tahoe-sites-cannot-import

Conversation

@shadinaif

@shadinaif shadinaif commented Sep 12, 2022

Copy link
Copy Markdown

Change description

Fix: cannot import tahoe-sites, not ready yet. A bug I made while refactoring in favor of tahoe-sites

error message:

....
  File "/edx/app/edxapp/edx-platform/openedx/core/djangoapps/appsembler/settings/settings/production_lms.py", line 8, in <module>
    from ..helpers import get_tahoe_theme_static_dirs, get_tahoe_multitenant_auth_backends
....
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/conf/__init__.py", line 171, in __init__
    raise ImproperlyConfigured("The %s setting must be a list or a tuple. " % setting)
django.core.exceptions.ImproperlyConfigured: The LOCALE_PATHS setting must be a list or a tuple.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Related to #1213

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@github-actions

Copy link
Copy Markdown

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/koa.master
Benchmark conflicts with main 111
Current conflicts 111
Summary Good work! No added conflicts.
Comparing with open-release/lilac.master
Benchmark conflicts with main 254
Current conflicts 254
Summary Good work! No added conflicts.
Comparing with open-release/maple.master
Benchmark conflicts with main 285
Current conflicts 285
Summary Good work! No added conflicts.
Comparing with open-release/nutmeg.master
Benchmark conflicts with main 293
Current conflicts 293
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 289
Current conflicts 289
Summary Good work! No added conflicts.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3035106062

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.0005%) to 49.032%

Files with Coverage Reduction New Missed Lines %
common/lib/xmodule/xmodule/partitions/enrollment_track_partition_generator.py 1 71.43%
lms/djangoapps/course_blocks/transformers/user_partitions.py 1 75.29%
openedx/core/djangoapps/content/block_structure/block_structure.py 1 94.86%
Totals Coverage Status
Change from base Build 3021958691: 0.0005%
Covered Lines: 110951
Relevant Lines: 226283

💛 - Coveralls

@shadinaif
shadinaif merged commit 3d7e7f6 into main Sep 12, 2022
@shadinaif
shadinaif deleted the shadinaif/fix-tahoe-sites-cannot-import branch September 12, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants