Final preperations to de-fork our edx-organizations - #1213
Conversation
This comment has been minimized.
This comment has been minimized.
4780712 to
811a31e
Compare
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 3008827825
💛 - Coveralls |
There was a problem hiding this comment.
Great for this pull request.
A note for the future: If we end up needing this a lot, I think it makes sense to add another API:
get_organization_for_course(course_id)
We can replace get_site_for_course into get_site_by_organization(get_organization_for_course(course_id))
f04f74e to
b3b50f7
Compare
This comment has been minimized.
This comment has been minimized.
b3b50f7 to
15e61b7
Compare
This comment has been minimized.
This comment has been minimized.
15e61b7 to
07c0b37
Compare
This comment has been minimized.
This comment has been minimized.
07c0b37 to
13cee8b
Compare
This comment has been minimized.
This comment has been minimized.
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @shadinaif!
I have many requested changes. The PR overall looks good, but we must do the following:
Requested changes:
- revert changes on
legacy_amc_helpers.pyto avoid breaking production AMC sites - undo
add_organizationchanges - ask bryan to review the removal of TAHOE_ENABLE_MULTI_ORGS_PER_SITE
|
@shadinaif regarding I've wrote a blog post which you can use for future reference: |
13cee8b to
cfe3329
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
7d30777 to
356309d
Compare
This comment has been minimized.
This comment has been minimized.
356309d to
c1f8f7b
Compare
This comment has been minimized.
This comment has been minimized.
c1f8f7b to
7b5a5be
Compare
This comment has been minimized.
This comment has been minimized.
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @shadinaif!! One more optional change.
Looks good!
7b5a5be to
e64355c
Compare
This comment has been minimized.
This comment has been minimized.
e64355c to
383ac7b
Compare
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
|
Change description
This is considered part of refactoring
edx-organizationsinto the newtahoe-sitespackageTAHOE_ENABLE_MULTI_ORGS_PER_SITEfeature flagType of change
Related issues
Related to: https://appsembler.atlassian.net/browse/RED-3274
Checklists
Development
Security
Code review