This repository was archived by the owner on Jul 5, 2024. It is now read-only.
op CALLDATALOAD#346
Merged
ChihChengLiang merged 11 commits intoMar 14, 2022
Merged
Conversation
github-actions
Bot
added
crate-bus-mapping
roynalnaruto
force-pushed
the
feat/calldataload
branch
from
da08a28 to
d41ebfd
Compare
icemelon
reviewed
Feb 24, 2022
roynalnaruto
force-pushed
the
feat/calldataload
branch
from
2c88d1d to
baca4f3
Compare
icemelon
reviewed
Mar 1, 2022
icemelon
reviewed
Mar 3, 2022
icemelon
approved these changes
Mar 3, 2022
Collaborator
icemelon
left a comment
icemelon
left a comment
There was a problem hiding this comment.
LGTM
@ed255 @ChihChengLiang @han0110 Could you help review this PR?
19 tasks
CPerezz
approved these changes
Mar 10, 2022
11 tasks
Collaborator
|
Let's merge this as it has 2 effective reviews. Post merge review is welcomed. |
zemse
pushed a commit
to zemse/zkevm-circuits
that referenced
this pull request
Mar 22, 2023
…m#346) Co-authored-by: Aurélien Nicolas <info@nau.re>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specs PR here