Skip to content

Adjust API Availability for Structured Concurrency Backport#18

Merged
ktoso merged 3 commits intoapple:mainfrom
moritzsternemann:concurrency-backport
Jan 18, 2022
Merged

Adjust API Availability for Structured Concurrency Backport#18
ktoso merged 3 commits intoapple:mainfrom
moritzsternemann:concurrency-backport

Conversation

@moritzsternemann
Copy link
Copy Markdown
Contributor

As the Swift Structured Concurrency backport is now available with the release of Xcode 13.2, I adjusted the API availability guards to enable these features on previous OS versions.

I'll also open a follow-up PR in swift-distributed-tracing.

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

3 similar comments
@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

Copy link
Copy Markdown
Collaborator

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @moritzsternemann! Looks good to me ✅ I'm wondering if we should also add #if compiler(>=5.5.2) && canImport(_Concurrency), because that's how it's currently handled in NIO. CC @ktoso, @fabianfett

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 17, 2022

@swift-server-bot test this please

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 17, 2022

Yeah the #if also has to be adjusted to what we explain in the adoption guidelines: https://github.com/swift-server/guides/blob/main/docs/concurrency-adoption-guidelines.md#if-guarding-code-using-concurrency

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 17, 2022

Our "good friend" jazzy messing up builds again, I'll fix this.

@slashmo
Copy link
Copy Markdown
Collaborator

slashmo commented Jan 17, 2022

Our "good friend" jazzy messing up builds again, I'll fix this.
@ktoso

Now that DocC seems to be able to generate static websites as well (swiftlang/swift-docc#56), I think we can ditch Jazzy as soon as possible.

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 17, 2022

Very true, to be honest perhaps let's not even waste energy on jazzy anymore.

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 18, 2022

@swift-server-bot test this please

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 18, 2022

I updated the check: 46faa2a

Would you mind doing the same in the other repo @moritzsternemann ?

@ktoso ktoso enabled auto-merge (squash) January 18, 2022 01:30
@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 18, 2022

@swift-server-bot add to allowlist

@ktoso ktoso merged commit 16fe42c into apple:main Jan 18, 2022
@moritzsternemann moritzsternemann deleted the concurrency-backport branch January 18, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants