Skip to content

Adjust API Availability for Structured Concurrency Backport#58

Merged
ktoso merged 2 commits intoapple:mainfrom
moritzsternemann:concurrency-backport
Jan 19, 2022
Merged

Adjust API Availability for Structured Concurrency Backport#58
ktoso merged 2 commits intoapple:mainfrom
moritzsternemann:concurrency-backport

Conversation

@moritzsternemann
Copy link
Copy Markdown
Contributor

@moritzsternemann moritzsternemann commented Jan 16, 2022

As the Swift Structured Concurrency backport is now available with the release of Xcode 13.2, I adjusted the API availability guards to enable these features on previous OS versions.

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

4 similar comments
@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@swift-server-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 17, 2022

@swift-server-bot test this please

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 17, 2022

ah meh, too early

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 18, 2022

Thanks for the PR; would you mind fixing the #if the same way as we did here: apple/swift-service-context@46faa2a ? Thanks!

@ktoso ktoso requested review from ktoso and slashmo January 18, 2022 01:34
@moritzsternemann
Copy link
Copy Markdown
Contributor Author

Thanks for the review and fix @ktoso! Are you going to draft a release for the baggage package so we can change the dependency version in this PR?

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 18, 2022

@swift-server-bot add to allowlist

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 18, 2022

Sure we can tag if you want -- are you using this package already? In what capacity / situation?

@ktoso ktoso marked this pull request as ready for review January 18, 2022 22:53
@moritzsternemann
Copy link
Copy Markdown
Contributor Author

I'm currently working on my bachelor's thesis in the realm of distributed tracing. At the chair, we are developing a declarative framework for building web services in Swift, called Apodini. My focus is in part to add distributed tracing capabilities, which is where swift-distributed-tracing comes in 🚀

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 19, 2022

That looks quite nice :-) Well done and good luck with the thesis!
Feel free to reach out here or on the https://forums.swift.org with any questions, happy to support.

@ktoso ktoso merged commit 243c601 into apple:main Jan 19, 2022
@moritzsternemann
Copy link
Copy Markdown
Contributor Author

Thank you!

In the current state of main after merging this PR, the package doesn't build on macOS, because the Baggage.current TaskLocal property is of course only available on macOS 12 in the 0.2.x release. I think the CI checks only run on Linux, do they?

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 28, 2022

Yeah, we only have Linux CI, however with the bump of the dependency to 0.2.2 things build fine AFAIK (I built locally, seems good).

I just tagged 0.2.2 here as well, feel free to try.
Sorry I'm a bit in a rush with those things, hope I got it right :-)

@ktoso
Copy link
Copy Markdown
Member

ktoso commented Jan 28, 2022

FYI @moritzsternemann

@moritzsternemann
Copy link
Copy Markdown
Contributor Author

Looks good to me as well, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants