Fix 5.9 and nightly allocation limits (#2485) #2487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation Our 5.9 and nightly CI has been failing for some time now due to flaky allocation tests. # Modification This PR slightly changes some shared infra for how we ran some of our allocation tests. We are now waiting for the client and server channel to close so that allocations are more stable. # Results Green CI again
FranzBusch
force-pushed
the
fb-allocation-limits
branch
from
18a0534 to
14feb86
Compare
|
@swift-nio-bot test this please |
1 similar comment
|
@swift-nio-bot test this please |
|
Looks stable now. 3 runs in a row without failing tests. |
gjcairo
approved these changes
Jul 31, 2023
glbrntt
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our 5.9 and nightly CI has been failing for some time now due to flaky allocation tests.
Modification
This PR slightly changes some shared infra for how we ran some of our allocation tests. We are now waiting for the client and server channel to close so that allocations are more stable.
Results
Green CI again