Skip to content

Commit 18a0534

Browse files
committed
Fix 5.9 and nightly allocation limits (#2485)
# Motivation Our 5.9 and nightly CI has been failing for some time now due to flaky allocation tests. # Modification This PR slightly changes some shared infra for how we ran some of our allocation tests. We are now waiting for the client and server channel to close so that allocations are more stable. # Results Green CI again
1 parent e77a948 commit 18a0534

File tree

1 file changed

+3
-1
lines changed
  • IntegrationTests/tests_04_performance/test_01_resources

1 file changed

+3
-1
lines changed

IntegrationTests/tests_04_performance/test_01_resources/shared.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ func doRequests(group: EventLoopGroup, number numberOfRequests: Int) throws -> I
130130

131131
clientChannel.write(NIOAny(HTTPClientRequestPart.head(RepeatedRequests.requestHead)), promise: nil)
132132
try clientChannel.writeAndFlush(NIOAny(HTTPClientRequestPart.end(nil))).wait()
133-
return try repeatedRequestsHandler.wait()
133+
let result = try repeatedRequestsHandler.wait()
134+
try clientChannel.closeFuture.wait()
135+
return result
134136
}
135137

136138
func withAutoReleasePool<T>(_ execute: () throws -> T) rethrows -> T {

0 commit comments

Comments
 (0)