Fix SPI argument parsing issue #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've deployed a fix in our builder so this shouldn't be necessary. I'll kick off a rebuild of the package to confirm. |
|
Confirmed fixed, this PR is not needed: SwiftPackageIndex/SwiftPackageIndex-Server#3374 (comment) |
Yes. The PR is no longer required. That said. Still think it makes the config more clear that we write each parameter as a separate element. I'll wait for @rauhul's review opinion for this. |
|
I do prefer these as separate lines as its more clear that it isn't one arg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close SwiftPackageIndex/SwiftPackageIndex-Server#3374
TL,DR: SwiftPackageIndex/SwiftPackageIndex-Server#3374 (comment)
Previous PR: