Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong flag passed to swift-docc-plugin #118

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Aug 28, 2024

Fix wrong flag passed to swift-docc-plugin

See detail in #104 (comment)

Tested it locally this time via the same command SPI is using.

xcrun swift package --allow-writing-to-directory .docs/apple/swift-mmio/main generate-documentation --emit-digest --disable-indexing --output-path .docs/apple/swift-mmio/main --hosting-base-path apple/swift-mmio/main --source-service github --source-service-base-url https://github.com/apple/swift-mmio/blob/main --checkout-path $PWD --target MMIO --symbol-graph-minimum-access-level public

This time Error: Unknown option '--minimum-access-level public' would be solved.

But I still get the following same error on SPI build. Anyway this seems to be SPI issue and I have report it to upstream via SwiftPackageIndex/SwiftPackageIndex-Server#3343.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@Kyle-Ye Kyle-Ye requested a review from rauhul as a code owner August 28, 2024 07:51
@rauhul rauhul merged commit 4357d91 into apple:main Aug 28, 2024
5 checks passed
@Kyle-Ye Kyle-Ye deleted the optimize/kyle/doc branch August 29, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants