Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common image attributes #529

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Add common image attributes #529

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be9c90d
Add common image attributes
zadeviggers Jan 24, 2022
5fccedb
Allow srcset
zadeviggers Jan 25, 2022
43f28f3
Update changelog
zadeviggers Jan 25, 2022
1971a57
Update defaults in readme
zadeviggers Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,10 +780,10 @@ sanitizeHtml.defaults = {
disallowedTagsMode: 'discard',
allowedAttributes: {
a: [ 'href', 'name', 'target' ],
// We don't currently allow img itself by default, but this
// We don't currently allow img itself by default, but these
// would make sense if we did. You could add srcset here,
// and if you do the URL is checked for safety
img: [ 'src' ]
img: [ 'src', 'alt', 'title', 'width', 'height', 'loading' ]
zadeviggers marked this conversation as resolved.
Show resolved Hide resolved
},
// Lots of these won't come up by default because we don't allow them
selfClosing: [ 'img', 'br', 'hr', 'area', 'base', 'basefont', 'input', 'link', 'meta' ],
Expand Down