Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common image attributes #529

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Add common image attributes #529

merged 4 commits into from
Jan 25, 2022

Conversation

zadeviggers
Copy link
Contributor

@zadeviggers zadeviggers commented Jan 24, 2022

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"

Allow common image attributes by default. If the src attribute is going to be enabled without images being enabled, it makes sense to also allow other commonly used tags to reduce confusion when using the library.

The alt attribute is also required on <img /> tags by the HTML standard so it shouldn't be removed by default.

Closes #525

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

index.js Outdated Show resolved Hide resolved
@zadeviggers zadeviggers requested a review from boutell January 25, 2022 01:16
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@boutell boutell merged commit 7338f8b into apostrophecms:main Jan 25, 2022
@zadeviggers zadeviggers deleted the patch-1 branch January 25, 2022 22:48
@zadeviggers zadeviggers restored the patch-1 branch January 25, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow alt attribute on img by default
2 participants