Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version defaults to install scripts #324

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Mar 3, 2021

Fixes #88

Description

This PR changes the two install scripts to behave similarly to each other, each taking the best parts of the other to provide a friendly and intuitive install process for rover :)

Windows changes

Old Behavior
The old installer script only had the ability to download the version it was released with, i.e. the installer released with 0.0.2 could only install rover 0.0.2.

New Behavior
By default, if no VERSION env variable is present, the windows install script will install the version of Rover the corresponding script was released with, similar to before.

The change here is you can now use the $Env:VERSION env variable to override the default version, and download another version of the Rover binary.

win

Old Behavior
The old installer could only install the rover version defined by the VERSION env variable.

New Behavior
By default, if no VERSION env variable is present, the nix install script will install the version of Rover the corresponding script was released with. Passing the VERSION env variable overrides the default version, and downloads another version of the Rover binary.

No VERSION env variable is needed when executing the script anymore.

nix


Fun notes

  • I've also tested that appending the corresponding env variable set lines to these files should allow orbiter to set the version at runtime as well :wendyparrot:
  • This also fixes the footgun we almost introduced for npm users. If we had made the script check for latest, npm users installing 0.0.3, for example, always would've been installing the latest version (which we definitely would have heard about)

@JakeDawkins JakeDawkins added the feature 🎉 new commands, flags, functionality, and improved error messages label Mar 3, 2021
@JakeDawkins JakeDawkins added this to the March 9 milestone Mar 3, 2021
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to open an issue for updating these hard coded versions as part of our build.rs process?

Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

(and thank you for a detailed description, btw!)

@JakeDawkins JakeDawkins merged commit 9f5ca25 into main Mar 5, 2021
@JakeDawkins JakeDawkins deleted the jake/winstallnix branch March 5, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set $VERSION statically in curl installer
3 participants