Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build step for setting installer version #327

Closed
JakeDawkins opened this issue Mar 5, 2021 · 1 comment
Closed

Add build step for setting installer version #327

JakeDawkins opened this issue Mar 5, 2021 · 1 comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone
March 23

Comments

@JakeDawkins
Copy link
Contributor

Description

Related to #324

The installers both have hard-coded default versions for which version of Rover to download.

We should automate the process of setting that default during the build process. It could pretty easily be done by simple string replacement
@JakeDawkins JakeDawkins added the feature 🎉 new commands, flags, functionality, and improved error messages label Mar 5, 2021
@EverlastingBugstopper
Copy link
Contributor

this was fixed with #332

@EverlastingBugstopper EverlastingBugstopper added this to the March 23 milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
March 23
Development

No branches or pull requests
2 participants
@JakeDawkins @EverlastingBugstopper