Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle malformed API key errors #275

Merged
merged 3 commits into from
Feb 19, 2021
Merged

fix: handle malformed API key errors #275

merged 3 commits into from
Feb 19, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

fixes #215

before:

$ rover config whoami --profile malformed-key
error: 406: Not Acceptable

after:

$ rover config whoami --profile malformed-key
error: The API key you provided is malformed. An API key must have three parts separated by a colon.
        Visit https://go.apollo.dev/r/api-keys for more details on Apollo's API keys.

@EverlastingBugstopper EverlastingBugstopper added this to the 0.0.2 milestone Feb 16, 2021
lrlna
lrlna reviewed Feb 18, 2021
View reviewed changes
crates/rover-client/src/blocking/client.rs
@@ -55,6 +55,10 @@ impl Client {
serde_json::from_str(&response_text)?;

if let Some(errs) = response_body.errors {
if !errs.is_empty() && errs[0].message.contains("406") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 😭 😭

(this sounds good though)

lrlna
lrlna approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lrlna lrlna merged commit 8f95a69 into main Feb 19, 2021
@lrlna lrlna deleted the avery/406 branch February 19, 2021 10:47
@lrlna lrlna mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna lrlna approved these changes

@JakeDawkins JakeDawkins Awaiting requested review from JakeDawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
February 23
Development

Successfully merging this pull request may close these issues.

Add error handling for 406 error
2 participants
@EverlastingBugstopper @lrlna