Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error experience from push #111

Closed
JakeDawkins opened this issue Dec 4, 2020 · 3 comments
Closed

Improve error experience from push #111

JakeDawkins opened this issue Dec 4, 2020 · 3 comments
Milestone

Comments

@JakeDawkins
Copy link
Contributor

Originally from #108 (comment)

When a graph push or subgraph push fails, we don't really have any context beyond the plain text that studio returns. It looks like:

Error: Failed while pushing to Apollo Studio. To see a full printout of the schema attempting to push, rerun with `--log debug`

Caused by:
    encountered a GraphQL error, registry responded with: Could not parse as a GraphQL schema. Are you sure that your proposed schema is a parsable GraphQL schema?

It'd be nice to have a more custom error experience here, with more instructions

@abernix abernix added this to the 🐣 0.1.0 milestone Dec 15, 2020
@lrlna
Copy link
Member

lrlna commented Feb 19, 2021

@JakeDawkins do you think this is fixed with #275 ?

@JakeDawkins
Copy link
Contributor Author

@lrlna I don't think so necessarily, but I also don't think we really need to work on this error state too much. I don't think we'll be able to return any more info about invalid schemas than what studio returns to us, so I'm fine with closing this

@lrlna
Copy link
Member

lrlna commented Feb 22, 2021

Ok, let us close this then and revisit at a later date if necessary!

@lrlna lrlna closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants