Add configurability to checks commands

crates/rover-client/src/query/graph/check.graphql

@@ -3,12 +3,14 @@ mutation CheckSchemaQuery(
   $variant: String
   $schema: String
   $gitContext: GitContextInput!
+  $config: HistoricQueryParameters!
 ) {
   service(id: $graphId) {
     checkSchema(
       proposedSchemaDocument: $schema
       baseSchemaTag: $variant
       gitContext: $gitContext
+      historicParameters: $config
     ) {
       targetUrl
       diffToPrevious {

crates/rover-client/src/query/graph/check.rs

@@ -4,6 +4,7 @@ use graphql_client::*;
 
 use reqwest::Url;
 
+type Timestamp = String;
 #[derive(GraphQLQuery)]
 // The paths are relative to the directory where your `Cargo.toml` is located.
 // Both json and the GraphQL schema language are supported as sources for the schema

crates/rover-client/src/query/subgraph/check.graphql

@@ -4,13 +4,15 @@
     $implementingServiceName: String!
     $partialSchema: PartialSchemaInput!
     $gitContext: GitContextInput!
+    $config: HistoricQueryParameters!
   ) {
     service(id: $graph_id) {
       checkPartialSchema(
         graphVariant: $variant
         implementingServiceName: $implementingServiceName
         partialSchema: $partialSchema
         gitContext: $gitContext
+        historicParameters: $config
       ) {
         compositionValidationResult {
           errors {

crates/rover-client/src/query/subgraph/check.rs

@@ -4,6 +4,7 @@ use graphql_client::*;
 
 use reqwest::Url;
 
+type Timestamp = String;
 #[derive(GraphQLQuery)]
 // The paths are relative to the directory where your `Cargo.toml` is located.
 // Both json and the GraphQL schema language are supported as sources for the schema

src/command/graph/check.rs

@@ -8,7 +8,10 @@ use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::git::GitContext;
 use crate::utils::loaders::load_schema_from_flag;
-use crate::utils::parsers::{parse_graph_ref, parse_schema_source, GraphRef, SchemaSource};
+use crate::utils::parsers::{
+    parse_graph_ref, parse_query_count_threshold, parse_query_percentage_threshold,
+    parse_schema_source, parse_validation_period, GraphRef, SchemaSource, ValidationPeriod,
+};
 use crate::Result;
 
 #[derive(Debug, Serialize, StructOpt)]
@@ -29,6 +32,21 @@ pub struct Check {
     #[structopt(long, short = "s", parse(try_from_str = parse_schema_source))]
     #[serde(skip_serializing)]
     schema: SchemaSource,
+
+    /// Minimum number of requests within the time window for a query to be
+    /// considered
+    #[structopt(long, parse(try_from_str = parse_query_count_threshold))]
+    query_count_threshold: Option<i64>,
+
+    /// Minimum percentage of requests within the time window for a query to be
+    /// considered, relative to total request count. Expected values are 0-5
+    /// (i.e. minimum 5% of total request volume)
+    #[structopt(long, parse(try_from_str = parse_query_percentage_threshold))]
+    query_percentage_threshold: Option<f64>,
+
+    /// Size of the time window with which to validate schema against (in seconds)
+    #[structopt(long, parse(try_from_str = parse_validation_period))]
+    validation_period: Option<ValidationPeriod>,
 }
 
 impl Check {
@@ -45,6 +63,16 @@ impl Check {
                 variant: Some(self.graph.variant.clone()),
                 schema: Some(sdl),
                 git_context: git_context.into(),
+                config: check::check_schema_query::HistoricQueryParameters {
+                    query_count_threshold: self.query_count_threshold,
+                    query_count_threshold_percentage: self.query_percentage_threshold,
+                    from: self.validation_period.clone().unwrap_or_default().from,
+                    to: self.validation_period.clone().unwrap_or_default().to,
+                    // we don't support configuring these, but we can't leave them out
+                    excluded_clients: None,
+                    ignored_operations: None,
+                    included_variants: None,
+                },
             },
             &client,
         )?;

src/command/subgraph/check.rs

@@ -9,7 +9,10 @@ use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::git::GitContext;
 use crate::utils::loaders::load_schema_from_flag;
-use crate::utils::parsers::{parse_graph_ref, parse_schema_source, GraphRef, SchemaSource};
+use crate::utils::parsers::{
+    parse_graph_ref, parse_query_count_threshold, parse_query_percentage_threshold,
+    parse_schema_source, parse_validation_period, GraphRef, SchemaSource, ValidationPeriod,
+};
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Check {
@@ -34,6 +37,21 @@ pub struct Check {
     #[structopt(long, short = "s", parse(try_from_str = parse_schema_source))]
     #[serde(skip_serializing)]
     schema: SchemaSource,
+
+    /// Minimum number of requests within the time window for a query to be
+    /// considered
+    #[structopt(long, parse(try_from_str = parse_query_count_threshold))]
+    query_count_threshold: Option<i64>,
+
+    /// Minimum percentage of requests within the time window for a query to be
+    /// considered, relative to total request count. Expected values are 0-5
+    /// (i.e. minimum 5% of total request volume)
+    #[structopt(long, parse(try_from_str = parse_query_percentage_threshold))]
+    query_percentage_threshold: Option<f64>,
+
+    /// Size of the time window with which to validate schema against (in seconds)
+    #[structopt(long, parse(try_from_str = parse_validation_period))]
+    validation_period: Option<ValidationPeriod>,
 }
 
 impl Check {
@@ -59,6 +77,16 @@ impl Check {
                 partial_schema,
                 implementing_service_name: self.subgraph.clone(),
                 git_context: git_context.into(),
+                config: check::check_partial_schema_query::HistoricQueryParameters {
+                    query_count_threshold: self.query_count_threshold,
+                    query_count_threshold_percentage: self.query_percentage_threshold,
+                    from: self.validation_period.clone().unwrap_or_default().from,
+                    to: self.validation_period.clone().unwrap_or_default().to,
+                    // we don't support configuring these, but we can't leave them out
+                    excluded_clients: None,
+                    ignored_operations: None,
+                    included_variants: None,
+                },
             },
             &client,
         )?;

src/utils/parsers.rs

@@ -1,4 +1,5 @@
 use regex::Regex;
+use serde::Serialize;
 use std::{fmt, path::PathBuf};
 
 use crate::{anyhow, Result};
@@ -60,6 +61,47 @@ pub fn parse_graph_ref(graph_id: &str) -> Result<GraphRef> {
     }
 }
 
+#[derive(Debug, Serialize, Default, Clone)]
+pub struct ValidationPeriod {
+    pub from: Option<String>,
+    pub to: Option<String>,
+}
+
+/// Validation period is a positive number of seconds to validate in the past.
+// We just need to validate and negate it
+pub fn parse_validation_period(period: &str) -> Result<ValidationPeriod> {
+    let window = period.parse::<i64>()?;
+    if window > 0 {
+        Ok(ValidationPeriod {
+            from: Some(format!("{}", -window)),
+            to: Some("-1".to_string()),
+        })
+    } else {
+        Err(
+            anyhow!("Invalid validation period. Must be a positive number of seconds.".to_string())
+                .into(),
+        )
+    }
+}
+
+pub fn parse_query_count_threshold(threshold: &str) -> Result<i64> {
+    let threshold = threshold.parse::<i64>()?;
+    if threshold < 1 {
+        Err(anyhow!("Invalid value for query count threshold. Must be a positive integer.").into())
+    } else {
+        Ok(threshold)
+    }
+}
+
+pub fn parse_query_percentage_threshold(threshold: &str) -> Result<f64> {
+    let threshold = threshold.parse::<i64>()?;
+    if threshold <= 0 || threshold >= 100 {
+        Err(anyhow!("Invalid value for query percentage threshold. Must be a positive integer greater than 0 and less than 100").into())
+    } else {
+        Ok((threshold / 100) as f64)
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::{parse_graph_ref, parse_schema_source, GraphRef, SchemaSource};