Add configurability to checks commands #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeDawkins
requested review from
EverlastingBugstopper and
lrlna
as code owners
JakeDawkins
added
changelog - feature
feature 🎉
JakeDawkins
changed the title
JakeDawkins
force-pushed
the
jake/checks-options
branch
from
af807ba
to
e60041f
Compare
JakeDawkins
commented
Feb 4, 2021
JakeDawkins
commented
Feb 4, 2021
JakeDawkins
changed the title
This was
linked to
issues
Feb 5, 2021
lrlna
reviewed
Feb 8, 2021
EverlastingBugstopper
approved these changes
Feb 8, 2021
lrlna
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration options for checks commands, similar to the original
apollooptions. I also added a parser for the values, so the validation logic could be shared between the twoNotes:
chrono, but I'm also not certain it's necessary. It, after all, is just a prettier format of number of seconds for our use case.