Skip to content

fix: handle both 'deprecated' enum values when merging coprocessor context (backport #8913)#8997

Merged
carodewig merged 3 commits intodev-v2.10.xfrom
mergify/bp/dev-v2.10.x/pr-8913
Mar 12, 2026
Merged

fix: handle both 'deprecated' enum values when merging coprocessor context (backport #8913)#8997
carodewig merged 3 commits intodev-v2.10.xfrom
mergify/bp/dev-v2.10.x/pr-8913

Conversation

@carodewig
Copy link
Copy Markdown
Contributor

@carodewig carodewig commented Mar 10, 2026

#8679 inadvertently deleted deprecated keys when context: true was passed in the router config. One side effect of this was that client names no longer showed up in studio.

The quick-fix in the router config is to pass context: deprecated instead, but this will solve the issue more broadly.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

[ROUTER-1612]: https://apollographql.atlassian.net/browse/ROUTER-1612?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


This is an automatic backport of pull request #8913 done by Mergify.

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

…ntext (#8913)

(cherry picked from commit 7b18b3d)

# Conflicts:
#	apollo-router/src/plugins/coprocessor/test.rs
@carodewig carodewig requested a review from a team as a code owner March 10, 2026 13:59
@mergify mergify bot added the conflicts label Mar 10, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 10, 2026

Cherry-pick of 7b18b3d has failed:

On branch mergify/bp/dev-v2.10.x/pr-8913
Your branch is up to date with 'origin/dev-v2.10.x'.

You are currently cherry-picking commit 7b18b3da.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changesets/fix_caroline_rh_1292.md
	modified:   apollo-router/src/plugins/coprocessor/mod.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   apollo-router/src/plugins/coprocessor/test.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Mar 10, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

1 new, 55 changed, 5 removed
+ graphos/routing/(latest)/customization/coprocessor.mdx
* graphos/routing/(latest)/about-v2.mdx
* graphos/routing/(latest)/errors.mdx
* graphos/routing/(latest)/license.mdx
* graphos/routing/(latest)/uplink.mdx
* graphos/routing/(latest)/cloud/aws-migration.mdx
* graphos/routing/(latest)/cloud/configuration.mdx
* graphos/routing/(latest)/cloud/custom-domains.mdx
* graphos/routing/(latest)/cloud/dedicated-quickstart.mdx
* graphos/routing/(latest)/cloud/dedicated.mdx
* graphos/routing/(latest)/cloud/index.mdx
* graphos/routing/(latest)/cloud/lattice-configuration.mdx
* graphos/routing/(latest)/cloud/lattice-management.mdx
* graphos/routing/(latest)/cloud/lattice-troubleshooting.mdx
* graphos/routing/(latest)/cloud/migrate-to-dedicated.mdx
* graphos/routing/(latest)/cloud/secure-subgraphs.mdx
* graphos/routing/(latest)/cloud/serverless.mdx
* graphos/routing/(latest)/cloud/subscriptions.mdx
* graphos/routing/(latest)/cloud/throughput-guide.mdx
* graphos/routing/(latest)/configuration/cli.mdx
* graphos/routing/(latest)/configuration/envvars.mdx
* graphos/routing/(latest)/configuration/overview.mdx
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/customization/native-plugins.mdx
* graphos/routing/(latest)/customization/coprocessor/index.mdx
* graphos/routing/(latest)/customization/coprocessor/reference.mdx
* graphos/routing/(latest)/customization/rhai/reference.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/spans.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/standard-instruments.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/telemetry-pipelines/metrics-exporters/overview.mdx
* graphos/routing/(latest)/operations/subscriptions/api-gateway.mdx
* graphos/routing/(latest)/operations/subscriptions/configuration.mdx
* graphos/routing/(latest)/operations/subscriptions/overview.mdx
* graphos/routing/(latest)/performance/traffic-shaping.mdx
* graphos/routing/(latest)/performance/caching/response-caching/faq.mdx
* graphos/routing/(latest)/performance/caching/response-caching/invalidation.mdx
* graphos/routing/(latest)/performance/caching/response-caching/observability.mdx
* graphos/routing/(latest)/performance/caching/response-caching/quickstart.mdx
* graphos/routing/(latest)/query-planning/caching.mdx
* graphos/routing/(latest)/security/demand-control.mdx
* graphos/routing/(latest)/security/index.mdx
* graphos/routing/(latest)/security/jwt.mdx
* graphos/routing/(latest)/security/persisted-queries.mdx
* graphos/routing/(latest)/security/router-authentication.mdx
* graphos/routing/(latest)/self-hosted/index.mdx
* graphos/routing/(latest)/self-hosted/containerization/aws.mdx
* graphos/routing/(latest)/self-hosted/containerization/azure.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker-router-only.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker.mdx
* graphos/routing/(latest)/self-hosted/containerization/gcp.mdx
* graphos/routing/(latest)/self-hosted/containerization/index.mdx
* graphos/routing/(latest)/self-hosted/containerization/kubernetes/quickstart.mdx
* graphos/routing/(latest)/upgrade/from-router-v1.mdx
* graphos/routing/(latest)/_sidebar.yaml
- graphos/routing/(latest)/cloud/migrate-to-self-hosted.mdx
- graphos/routing/(latest)/configuration/hot-reload-schema.mdx
- graphos/routing/(latest)/configuration/schema-file.mdx
- graphos/routing/(latest)/performance/circuit-breaking.mdx
- graphos/routing/(latest)/self-hosted/containerization/proxy-certificates.mdx

Build ID: be3fbac98610b1c8f9bc16d9
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/be3fbac98610b1c8f9bc16d9


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@carodewig carodewig enabled auto-merge (squash) March 10, 2026 15:40
@alyssahursh alyssahursh requested a review from a team March 11, 2026 17:14
@abernix
Copy link
Copy Markdown
Member

abernix commented Mar 11, 2026

This looks like it didn't cherrypick cleanly and needs merge conflicts fixed before review.

@abernix
Copy link
Copy Markdown
Member

abernix commented Mar 11, 2026

whoops. browser just updated when I sent that.

@carodewig carodewig merged commit 75cdae0 into dev-v2.10.x Mar 12, 2026
14 checks passed
@carodewig carodewig deleted the mergify/bp/dev-v2.10.x/pr-8913 branch March 12, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants