Skip to content

fix: handle both 'deprecated' enum values when merging coprocessor context#8913

Merged
carodewig merged 3 commits intodevfrom
caroline/rh-1292
Feb 24, 2026
Merged

fix: handle both 'deprecated' enum values when merging coprocessor context#8913
carodewig merged 3 commits intodevfrom
caroline/rh-1292

Conversation

@carodewig
Copy link
Copy Markdown
Contributor

@carodewig carodewig commented Feb 24, 2026

#8679 inadvertently deleted deprecated keys when context: true was passed in the router config. One side effect of this was that client names no longer showed up in studio.

The quick-fix in the router config is to pass context: deprecated instead, but this will solve the issue more broadly.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@carodewig carodewig requested a review from a team as a code owner February 24, 2026 17:55
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Feb 24, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 38b4c49e0aa28f7e8ebe4251
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@github-actions

This comment has been minimized.

@carodewig carodewig enabled auto-merge (squash) February 24, 2026 22:25
@carodewig carodewig merged commit 7b18b3d into dev Feb 24, 2026
15 checks passed
@carodewig carodewig deleted the caroline/rh-1292 branch February 24, 2026 22:34
@carodewig
Copy link
Copy Markdown
Contributor Author

@mergify backport dev-v2.10.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 10, 2026

backport dev-v2.10.x

✅ Backports have been created

Details

Cherry-pick of 7b18b3d has failed:

On branch mergify/bp/dev-v2.10.x/pr-8913
Your branch is up to date with 'origin/dev-v2.10.x'.

You are currently cherry-picking commit 7b18b3da.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changesets/fix_caroline_rh_1292.md
	modified:   apollo-router/src/plugins/coprocessor/mod.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   apollo-router/src/plugins/coprocessor/test.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

carodewig added a commit that referenced this pull request Mar 10, 2026
…ntext (#8913)

(cherry picked from commit 7b18b3d)

# Conflicts:
#	apollo-router/src/plugins/coprocessor/test.rs
carodewig added a commit that referenced this pull request Mar 12, 2026
@abernix abernix mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants