Skip to content

fix: support more types of nullable elements in response/entity cache keys#8923

Merged
carodewig merged 10 commits intodevfrom
caroline/rh-1101
Feb 27, 2026
Merged

fix: support more types of nullable elements in response/entity cache keys#8923
carodewig merged 10 commits intodevfrom
caroline/rh-1101

Conversation

@carodewig
Copy link
Contributor

@carodewig carodewig commented Feb 26, 2026

#8767 changed the entity and response caching keys to support nullable elements. The implementation covered the case of a field explicitly being set to null, but did not cover the following cases:

  • Nullable field being missing
  • Nullable list items

This PR adds support for those cases and corresponding tests.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@carodewig carodewig requested a review from a team as a code owner February 26, 2026 15:37
@apollo-librarian
Copy link

apollo-librarian bot commented Feb 26, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* graphos/routing/(latest)/operations/subscriptions/api-gateway.mdx
* graphos/routing/(latest)/security/router-authentication.mdx

Build ID: 3dcc66355a9a55120b013396
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/3dcc66355a9a55120b013396


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@github-actions

This comment has been minimized.

@carodewig carodewig enabled auto-merge (squash) February 27, 2026 15:14
@carodewig carodewig merged commit 0e32ea3 into dev Feb 27, 2026
15 checks passed
@carodewig carodewig deleted the caroline/rh-1101 branch February 27, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants