Skip to content

fix(response caching): nullable fields in entities#8767

Merged
bnjjj merged 6 commits intodevfrom
aaron/null-cache-keys
Jan 21, 2026
Merged

fix(response caching): nullable fields in entities#8767
bnjjj merged 6 commits intodevfrom
aaron/null-cache-keys

Conversation

@aaronArinder
Copy link
Contributor

@aaronArinder aaronArinder commented Dec 16, 2025


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team December 16, 2025 20:36
@github-actions

This comment has been minimized.

@apollo-librarian
Copy link

apollo-librarian bot commented Dec 16, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* graphos/routing/(latest)/performance/caching/response-caching/faq.mdx
* graphos/routing/(latest)/performance/caching/response-caching/quickstart.mdx

Build ID: 2a490a0c3fb4331058a93082
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/2a490a0c3fb4331058a93082

Copy link
Contributor

@bnjjj bnjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have a test for a @cacheTag to confirm it will set null

Copy link
Contributor

@bnjjj bnjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we will need to change the composition validators

if !is_fully_non_null(field) {
to allow @cacheTag to use a nullable argument

@aaronArinder aaronArinder force-pushed the aaron/null-cache-keys branch 2 times, most recently from 10992f6 to 63ebba4 Compare January 7, 2026 15:28
@aaronArinder aaronArinder requested review from a team as code owners January 7, 2026 15:28
@aaronArinder aaronArinder force-pushed the aaron/null-cache-keys branch from 63ebba4 to ab361e7 Compare January 7, 2026 15:58
@aaronArinder aaronArinder requested a review from a team as a code owner January 7, 2026 15:58
@aaronArinder aaronArinder force-pushed the aaron/null-cache-keys branch 2 times, most recently from 93f9c78 to e1d3ebd Compare January 7, 2026 18:50
@aaronArinder aaronArinder force-pushed the aaron/null-cache-keys branch from e1d3ebd to a0c6200 Compare January 20, 2026 19:35
aaronArinder and others added 4 commits January 20, 2026 16:20
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@aaronArinder aaronArinder force-pushed the aaron/null-cache-keys branch from 818c392 to ec7dc38 Compare January 20, 2026 21:20
@bnjjj bnjjj merged commit 85f1f78 into dev Jan 21, 2026
15 checks passed
@bnjjj bnjjj deleted the aaron/null-cache-keys branch January 21, 2026 06:51
@abernix abernix mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants