add parser recursion and lexical token metrics#8845
Conversation
|
@jhrldev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: c7e7c301981c8ea591d909b1 URL: https://www.apollographql.com/docs/deploy-preview/c7e7c301981c8ea591d909b1 |
This comment has been minimized.
This comment has been minimized.
3430f1a to
f9ee59a
Compare
da61785 to
abe6a4a
Compare
rohan-b99
left a comment
There was a problem hiding this comment.
Implementation looks good to me, I think we just need a changeset (cargo xtask changeset create)
|
@jhrldev I would recommend doing the changeset inside the PR. it makes backporting/cherry-picking easier if there is a single commit / no follow-up PR. My suggestion is to write an initial message and then apply our style guide edits to it using Claude/Copilot/Glean, and commit that within the context of this PR. |
4b68aae to
6965b8a
Compare
carodewig
left a comment
There was a problem hiding this comment.
I think we should add these metrics to the docs as well (probably docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/standard-instruments.mdx)
ebe4134 to
405d4e9
Compare
405d4e9 to
b529854
Compare
Adds two new metrics:
apollo.router.operations.recursionfor the number of recursion level reached, andapollo.router.operations.lexical_tokensfor the number of lexical tokens in a query.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩