[THIS UNBLOCKS DEV] fix(allowed features): int test, log, erroring

[aaronArinder]

---

kind of weird, but here's what you'll see in the failing ci/cd runs for the other branches:

• a log saying the jwt has expired (it hasn't)
• a router config validation failures

what happened:

• the logs changed because we crossed over the warnAt threshold (a few hours ago), so we aren't able to match on the logs we expect to be there
• some funky copy-pasting of the test, I think; we need replace_config_string() for the config to get the target values (otherwise it'll fail for an invalid uri char)
• some funky copy-pasting of the logs; we have an error-level log that should be warn saying the jwt has expired when it hasn't, it's just past it's warnAt date
• a bypass of the licensing when in a warnAt state (ie, we need to actually return an error, not just log out violations)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• PR description explains the motivation for the change and relevant context for reviewing
• PR description links appropriate GitHub/Jira tickets (creating when necessary)
• Changeset is included for user-facing changes
• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Metrics and logs are added³ and documented
• Tests added and passing⁴
  • Unit tests
  • Integration tests
  • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. ↩

4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[apollo-librarian]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 0a93565ac9c53698ee9709ce
Build Logs: View logs

[calvincestari]

I''m going to approve because it all seems correct to me; I understand the intent, the code looks correct, and we need to unblock PRs. I would still recommend getting someone more familiar with Router code to approve too though.