Skip to content

fix(helm): deploymentAnnotations value (backport #8164)#8202

Merged
abernix merged 1 commit into2.6.1from
mergify/bp/2.6.1/pr-8164
Sep 4, 2025
Merged

fix(helm): deploymentAnnotations value (backport #8164)#8202
abernix merged 1 commit into2.6.1from
mergify/bp/2.6.1/pr-8164

Conversation

@glasser
Copy link
Member

@glasser glasser commented Sep 4, 2025

This lets you put annotations on the deployment itself (as opposed to the pods within it, which is done with podAnnotations).

For example, you could use this to have
https://github.com/stakater/Reloader reload router when config maps or secrets change.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes


This is an automatic backport of pull request #8164 done by [Mergify](https://mergify.com).

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@glasser glasser requested a review from a team as a code owner September 4, 2025 17:35
@mergify mergify bot assigned glasser Sep 4, 2025
@mergify mergify bot mentioned this pull request Sep 4, 2025
10 tasks
@apollo-librarian
Copy link

apollo-librarian bot commented Sep 4, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 11 changed, 0 removed
* graphos/routing/(latest)/cloud/migrate-to-dedicated.mdx
* graphos/routing/(latest)/configuration/envvars.mdx
* graphos/routing/(latest)/configuration/cli.mdx
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/customization/custom-binary.mdx
* graphos/routing/(latest)/customization/overview.mdx
* graphos/routing/(latest)/observability/telemetry/instrumentation/selectors.mdx
* graphos/routing/(latest)/operations/file-upload.mdx
* graphos/routing/(latest)/security/persisted-queries.mdx
* graphos/routing/(latest)/security/request-limits.mdx
* graphos/routing/(latest)/graphos-features.mdx

Build ID: 21a2e3e2d8f1f9ce7beaa8db
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/21a2e3e2d8f1f9ce7beaa8db

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving on behalf of previous approvals

@abernix abernix enabled auto-merge September 4, 2025 17:41
@abernix abernix merged commit 145b50d into 2.6.1 Sep 4, 2025
14 checks passed
@abernix abernix deleted the mergify/bp/2.6.1/pr-8164 branch September 4, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants