Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 290115e2004c6710c33a0745 URL: https://www.apollographql.com/docs/deploy-preview/290115e2004c6710c33a0745 |
glasser
force-pushed
the
glasser/helm-deployment-annotations
branch
from
32f9318 to
d625ee2
Compare
There was a problem hiding this comment.
It is ok in k8s for an object to just be foo: with no values underneath.
aaronArinder
left a comment
aaronArinder
left a comment
There was a problem hiding this comment.
this seems safe without knowing how new, user-submitted annotations will be used; I'm assuming that's been thought about, but it's worth worrying about if not!
There was a problem hiding this comment.
what were the annotations doing before? it looks like duplicate blocks of the same annotations? now, it looks like we have the duplicate entries under the same annotations block?
There was a problem hiding this comment.
These are specific annotations defined by this field. This PR lets you also add your own annotations too.
We already let users add annotations to all sorts of other places, just not deployments. Providing hooks for arbitrary annotations is pretty standard for charts since Helm doesn't let you make these changes as a chart consumer without an explicit hook.
|
The example I mentioned in the PR above is letting you use https://github.com/stakater/Reloader While Router does have a hot reload mode for its config file, if you're using envVarsFromCM to load env vars from a config map, you may want your deployment to be restarted when you edit the env var config map. K8s doesn't do that by default; Reloader is a common piece of software to solve this problem but you enable it by adding an annotation to a Deployment. |
This lets you put annotations on the deployment itself (as opposed to the pods within it, which is done with podAnnotations). For example, you could use this to have https://github.com/stakater/Reloader reload router when config maps or secrets change.
glasser
force-pushed
the
glasser/helm-deployment-annotations
branch
from
d625ee2 to
ceb20ca
Compare
abernix
changed the title
|
@mergify backport 2.6.1 |
❌ No backport have been createdDetails
Unable to backport: user |
|
When this merges, Mergify will open the backport to 2.6.1. That will produce a new PR which needs approval, but is typically closer to a rubber-stamp, particularly when we're close enough in versions that there's no merge conflict. |
|
@mergify backport 2.6.1 |
✅ Backports have been createdDetails
|
(cherry picked from commit 5887c93)
4 participants
This lets you put annotations on the deployment itself (as opposed to the pods within it, which is done with podAnnotations).
For example, you could use this to have
https://github.com/stakater/Reloader reload router when config maps or secrets change.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩