Skip to content

Make the id field on ServerMessage::Error optional - as it can be ret… (copy #8181) (backport #8189)#8199

Merged
abernix merged 1 commit into2.6.1from
mergify/bp/2.6.1/pr-8189
Sep 4, 2025
Merged

Make the id field on ServerMessage::Error optional - as it can be ret… (copy #8181) (backport #8189)#8199
abernix merged 1 commit into2.6.1from
mergify/bp/2.6.1/pr-8189

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2025

This PR FIXES #6138. It brings @jeffutter's #8181 into a context where CI will run and lets me (@abernix) finish the changeset for it.

The websocket-transport-ws spec does not require an id on a CONNECTION_ERROR. This makes that field optional

Todo

  • Changeset
  • Backport and ship as 2.6.1
  • CLA check (@abernix signed off)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changes are compatible[^1]
  • Performance impact assessed and acceptable
  • Tests added and passing[^4]
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

This is an automatic copy of pull request #8181 done by [Mergify](https://mergify.com).

[ROUTER-1421]: https://apollographql.atlassian.net/browse/ROUTER-1421?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


This is an automatic backport of pull request #8189 done by Mergify.

Copies: #8181
Fixes: #6138
Co-authored-by: Jeffery Utter <jeffery.utter@thescore.com>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Renée <renee.kooi@apollographql.com>
(cherry picked from commit 6da9cdb)
@mergify mergify bot requested a review from a team September 4, 2025 15:19
@mergify mergify bot requested a review from a team as a code owner September 4, 2025 15:19
@apollo-cla
Copy link

@mergify[bot]: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@apollo-librarian
Copy link

apollo-librarian bot commented Sep 4, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 11 changed, 0 removed
* graphos/routing/(latest)/cloud/migrate-to-dedicated.mdx
* graphos/routing/(latest)/configuration/envvars.mdx
* graphos/routing/(latest)/configuration/cli.mdx
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/customization/custom-binary.mdx
* graphos/routing/(latest)/customization/overview.mdx
* graphos/routing/(latest)/observability/telemetry/instrumentation/selectors.mdx
* graphos/routing/(latest)/operations/file-upload.mdx
* graphos/routing/(latest)/security/persisted-queries.mdx
* graphos/routing/(latest)/security/request-limits.mdx
* graphos/routing/(latest)/graphos-features.mdx

Build ID: eb041c17d7ed21823654cb0d
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/eb041c17d7ed21823654cb0d

@abernix abernix merged commit 7b1f4c0 into 2.6.1 Sep 4, 2025
13 of 14 checks passed
@abernix abernix deleted the mergify/bp/2.6.1/pr-8189 branch September 4, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants