Make the id field on ServerMessage::Error optional - as it can be ret… (copy #8181)#8189
Merged
Make the id field on ServerMessage::Error optional - as it can be ret… (copy #8181)#8189
Conversation
…urned on INIT which doesn't have an id, and the spec for graphql-transport-ws specifies it as optional. (cherry picked from commit f564e68)
7 tasks
|
@mergify[bot]: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 1219167322286d328210672a |
This comment has been minimized.
This comment has been minimized.
Member
|
@Mergifyio backport 2.6.1 |
Contributor
Author
❌ No backport have been createdDetails
Unable to backport: Mergify can't impersonate a bot from another GitHub App: |
bnjjj
approved these changes
Sep 3, 2025
Co-authored-by: Renée <renee.kooi@apollographql.com>
goto-bus-stop
approved these changes
Sep 3, 2025
BrynCooke
approved these changes
Sep 3, 2025
Member
|
@Mergifyio backport 2.6.1 |
Contributor
Author
✅ Backports have been createdDetails
|
10 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR FIXES #6138. It brings @jeffutter's #8181 into a context where CI will run and lets me (@abernix) finish the changeset for it.
The
websocket-transport-wsspec does not require anidon aCONNECTION_ERROR. This makes that field optionalTodo
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
This is an automatic copy of pull request #8181 done by [Mergify](https://mergify.com).