Skip to content

Cleanup post router-bridge removal#6512

Merged
SimonSapin merged 2 commits intodevfrom
simon/qp-cleanup
Jan 10, 2025
Merged

Cleanup post router-bridge removal#6512
SimonSapin merged 2 commits intodevfrom
simon/qp-cleanup

Conversation

@SimonSapin
Copy link
Copy Markdown
Contributor

@SimonSapin SimonSapin commented Jan 6, 2025

Now that router-bridge has been removed in Router, some code that used to handle two different paths can now be simplified or removed. This intends to make no behavior change.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@SimonSapin SimonSapin requested a review from a team January 6, 2025 15:44
@SimonSapin SimonSapin requested a review from a team as a code owner January 6, 2025 15:44
@svc-apollo-docs
Copy link
Copy Markdown
Collaborator

svc-apollo-docs commented Jan 6, 2025

✅ Docs Preview Ready

No new or changed pages found.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2025

@SimonSapin, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link
Copy Markdown

router-perf bot commented Jan 6, 2025

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@SimonSapin SimonSapin merged commit a80938d into dev Jan 10, 2025
@SimonSapin SimonSapin deleted the simon/qp-cleanup branch January 10, 2025 14:58
mergify bot added a commit to BrynCooke/router that referenced this pull request Jan 15, 2025
* Cleanup post router-bridge removal (apollographql#6512)

* docs: instrumentation examples (apollographql#6487)

Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>

* chore(deps): Update dev dependencies with `npm audit fix` (apollographql#6544)

* Needs backporting

---------

Co-authored-by: Simon Sapin <simon@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: bryn <bryn@apollographql.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot pushed a commit to BrynCooke/router that referenced this pull request Jan 22, 2025
* Cleanup post router-bridge removal (apollographql#6512)

* docs: instrumentation examples (apollographql#6487)

Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>

* chore(deps): Update dev dependencies with `npm audit fix` (apollographql#6544)

* Needs backporting

* Needs backporting

---------

Co-authored-by: Simon Sapin <simon@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: bryn <bryn@apollographql.com>
BrynCooke added a commit to BrynCooke/router that referenced this pull request Jan 22, 2025
* Cleanup post router-bridge removal (apollographql#6512)

* docs: instrumentation examples (apollographql#6487)

Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>

* chore(deps): Update dev dependencies with `npm audit fix` (apollographql#6544)

* Needs backporting

* Needs backporting

---------

Co-authored-by: Simon Sapin <simon@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: bryn <bryn@apollographql.com>
(cherry picked from commit 99f5b36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants