Conversation
Collaborator
✅ Docs Preview ReadyNo new or changed pages found. |
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
Contributor
Author
|
!docs preview main |
Contributor
Author
|
!docs preview main |
Contributor
Author
|
!docs preview main |
BrynCooke
requested changes
Jan 7, 2025
docs/source/reference/router/telemetry/instrumentation/selectors.mdx
Outdated
Show resolved
Hide resolved
docs/source/reference/router/telemetry/instrumentation/selectors.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| ### Setting JSON paths | ||
|
|
||
| Configuring selectors with JSON paths, such as supergraph `response_data` and `response_errors`: |
Contributor
There was a problem hiding this comment.
This will create a high cardinality metric:
A better example is this:
telemetry:
exporters:
metrics:
prometheus:
enabled: true
instrumentation:
instruments:
supergraph:
my.request.on_graphql_error:
value: event_unit
type: counter
unit: error
description: my description
condition:
exists:
response_errors: "$.[0].extensions.code"
attributes:
response_errors:
response_errors: "$.[0].extensions.code"
…rs.mdx Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>
…rs.mdx Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>
BrynCooke
approved these changes
Jan 9, 2025
mergify bot
added a commit
to BrynCooke/router
that referenced
this pull request
Jan 15, 2025
* Cleanup post router-bridge removal (apollographql#6512) * docs: instrumentation examples (apollographql#6487) Co-authored-by: Bryn Cooke <BrynCooke@gmail.com> * chore(deps): Update dev dependencies with `npm audit fix` (apollographql#6544) * Needs backporting --------- Co-authored-by: Simon Sapin <simon@apollographql.com> Co-authored-by: Edward Huang <edward.huang@apollographql.com> Co-authored-by: Jesse Rosenberger <git@jro.cc> Co-authored-by: bryn <bryn@apollographql.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
pushed a commit
to BrynCooke/router
that referenced
this pull request
Jan 22, 2025
* Cleanup post router-bridge removal (apollographql#6512) * docs: instrumentation examples (apollographql#6487) Co-authored-by: Bryn Cooke <BrynCooke@gmail.com> * chore(deps): Update dev dependencies with `npm audit fix` (apollographql#6544) * Needs backporting * Needs backporting --------- Co-authored-by: Simon Sapin <simon@apollographql.com> Co-authored-by: Edward Huang <edward.huang@apollographql.com> Co-authored-by: Jesse Rosenberger <git@jro.cc> Co-authored-by: bryn <bryn@apollographql.com>
BrynCooke
added a commit
to BrynCooke/router
that referenced
this pull request
Jan 22, 2025
* Cleanup post router-bridge removal (apollographql#6512) * docs: instrumentation examples (apollographql#6487) Co-authored-by: Bryn Cooke <BrynCooke@gmail.com> * chore(deps): Update dev dependencies with `npm audit fix` (apollographql#6544) * Needs backporting * Needs backporting --------- Co-authored-by: Simon Sapin <simon@apollographql.com> Co-authored-by: Edward Huang <edward.huang@apollographql.com> Co-authored-by: Jesse Rosenberger <git@jro.cc> Co-authored-by: bryn <bryn@apollographql.com> (cherry picked from commit 99f5b36)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add example configurations for common use cases of selectors and conditions
Fast follows: