Skip to content

fix(subgraph_service): when the subgraph connection is closed or in error, return a proper subgraph response (#5859)#6065

Merged
abernix merged 4 commits into1.52.2from
bnjjj/backport_5859
Sep 26, 2024
Merged

fix(subgraph_service): when the subgraph connection is closed or in error, return a proper subgraph response (#5859)#6065
abernix merged 4 commits into1.52.2from
bnjjj/backport_5859

Conversation

@bnjjj
Copy link
Copy Markdown
Contributor

@bnjjj bnjjj commented Sep 26, 2024

This backports the fix from #5859 to a minor on 1.52.x, landing on top of https://github.com/apollographql/router/releases/tag/v1.52.1.

@abernix abernix marked this pull request as ready for review September 26, 2024 13:15
@abernix abernix requested a review from a team September 26, 2024 13:15
@abernix abernix requested a review from a team as a code owner September 26, 2024 13:15
@router-perf
Copy link
Copy Markdown

router-perf bot commented Sep 26, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

…rror, return a proper subgraph response (#5859)

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj force-pushed the bnjjj/backport_5859 branch from 6157fa6 to 8522001 Compare September 26, 2024 13:19
bnjjj and others added 3 commits September 26, 2024 16:05
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@abernix abernix merged commit 3ab650f into 1.52.2 Sep 26, 2024
@abernix abernix deleted the bnjjj/backport_5859 branch September 26, 2024 14:46
@apollo-bot2
Copy link
Copy Markdown

Detected SAST Vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants