fix(federation): misc fixes

[dariuszkuc]

Fixes

• Fix handling of SubgraphEnteringTransition which should skip RootTypeResolution edges. This fixes the issue with redundantly processing same edges over and over again.
• Fix handling of KeyResolution which should compare whole selection sets of the conditions vs just the selections.
• Ensures consistent order of child nodes when computing new key nodes
• Add missing self.on_modification() when removing redundant edges
• Returns false instead of throwing an error when calculating if new requires node is useless (i.e. return false if parent relation path is None)
• Fix PlanBuilder trait to no longer swallow exceptions from query planning

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Tests added and passing³
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[router-perf]

CI performance tests

• const - Basic stress test that runs with a constant number of users
• demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• enhanced-signature - Enhanced signature enabled
• events - Stress test for events with a lot of users and deduplication ENABLED
• events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• extended-reference-mode - Extended reference mode enabled
• large-request - Stress test with a 1 MB request payload
• no-tracing - Basic stress test, no tracing
• reload - Reload test over a long period of time at a constant rate of users
• step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• step-local-metrics - Field stats that are generated from the router rather than FTV1
• step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• step - Basic stress test that steps up the number of users over time
• xlarge-request - Stress test with 10 MB request payload
• xxlarge-request - Stress test with 100 MB request payload

[goto-bus-stop]

LGTM. We should keep the error but otherwise good to go in my opinion

[goto-bus-stop]

This will probably be slow when a fetch dependency node has very many children. Children are added one by one, so if this function is O(n), the complexity of adding many children is O(n^2). This is already a problem with add_parent and technically also with this loop, it will just be more pronounced if we also sort the children over and over.

I think it's okay if we do this here now, but we will have to improve the behaviour for nodes with many children in the near future.

[dariuszkuc]

Realistically this will be at most in the order of hundreds of nodes (maybe couple thousand?) so don't think this will have much impact but yeah something to keep in mind.

[goto-bus-stop]

We already have a query where we spend multiple seconds in add_parent because of this 😄

[duckki]

It looks good to me. I'm running corpus for comparison.

[duckki]

Corpus comparison result looks good. No new issues found.