Skip to content

feat: default to Apollo reporting over OTel #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lennyburdette merged 3 commits into from
Jul 31, 2024
Merged

feat: default to Apollo reporting over OTel #5741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baa1978
feat: default to Apollo reporting over OTel
lennyburdette Jul 29, 2024
1335717
changeset
lennyburdette Jul 30, 2024
0ec3a95
Apply suggestions from code review
lennyburdette Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changesets/breaking_lb_next_apollo_otel_default.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
### Default to Apollo reporting over OTel ([PR #5741](https://github.com/apollographql/router/pull/5741))

BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
Copy link
Contributor

@dylan-apollo dylan-apollo Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the config snippet to turn this back off?

Copy link
Contributor Author

@lennyburdette lennyburdette Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, i don't know the answer. it's possible that by the time 2.0 is GA, the option will be removed entirely, so i'm not going to worry about it right now



By [@lennyburdette](https://github.com/lennyburdette) in https://github.com/apollographql/router/pull/5741
2 changes: 1 addition & 1 deletion apollo-router/src/plugins/telemetry/apollo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ const fn default_field_level_instrumentation_sampler() -> SamplerOption {
}

const fn default_experimental_otlp_tracing_sampler() -> SamplerOption {
SamplerOption::Always(Sampler::AlwaysOff)
SamplerOption::Always(Sampler::AlwaysOn)
}

fn endpoint_default() -> Url {
Expand Down