feat: default to Apollo reporting over OTel#5741
Merged
lennyburdette merged 3 commits intonextfrom Jul 31, 2024
Merged
Conversation
BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
|
CI performance tests
|
Contributor
dylan-apollo
left a comment
There was a problem hiding this comment.
Makes sense to me, pretty sure I heard agreement on this change in a previous meeting
| @@ -0,0 +1,7 @@ | |||
| ### feat: default to Apollo reporting over OTel ([PR #5741](https://github.com/apollographql/router/pull/5741)) | |||
|
|
|||
| BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently | |||
Contributor
There was a problem hiding this comment.
Should we include the config snippet to turn this back off?
Contributor
Author
There was a problem hiding this comment.
great idea, i don't know the answer. it's possible that by the time 2.0 is GA, the option will be removed entirely, so i'm not going to worry about it right now
lennyburdette
commented
Jul 31, 2024
Co-authored-by: Dylan Anthony <dylan@apollographql.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩