Skip to content

Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab… #5665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garypen merged 6 commits into from
Aug 16, 2024
Merged

Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab… #5665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af7e621
Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab…
theJC Jul 16, 2024
1e6da59
Add changeset
theJC Jul 16, 2024
cc76906
Update condition checking maxSurge and maxUnavailable to hasKey so va…
theJC Jul 16, 2024
2c9b329
Update helm/chart/router/templates/deployment.yaml
theJC Jul 16, 2024
643e2e8
Update comment per PR comment suggestion
theJC Jul 27, 2024
8fba8e3
Merge branch 'dev' into helm_rollingupdate
Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changesets/feat_helm_rollingupdate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
### Support providing RollingUpdate maxSurge and maxUnavailable values ([Issue #5664](https://github.com/apollographql/router/issues/5664))

RollingUpdate maxSurge and maxUnavailable are commonly used deployment configuration values. This change makes their
values able to be set via the router helm chart.

By [Jon Christiansen](https://github.com/theJC) in https://github.com/apollographql/router/pull/5665
10 changes: 10 additions & 0 deletions helm/chart/router/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,13 @@ spec:
topologySpreadConstraints:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.rollingUpdate }}
strategy:
rollingUpdate:
{{- if (hasKey .Values.rollingUpdate "maxUnavailable") }}
maxUnavailable: {{ .Values.rollingUpdate.maxUnavailable }}
{{- end }}
{{- if (hasKey .Values.rollingUpdate "maxSurge") }}
maxSurge: {{ .Values.rollingUpdate.maxSurge }}
{{- end }}
{{- end }}
7 changes: 7 additions & 0 deletions helm/chart/router/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,13 @@ autoscaling:
# type: cpu
# targetUtilizationPercentage: 75

# -- Sets the [rolling update strategy parameters](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment). Can take absolute values or % values.
rollingUpdate:
{}
# Defaults if not set are:
# maxUnavailable: 25%
# maxSurge: 25%

nodeSelector: {}

tolerations: []
Expand Down