Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab…#5665
Merged
garypen merged 6 commits intoapollographql:devfrom Aug 16, 2024
Merged
Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab…#5665garypen merged 6 commits intoapollographql:devfrom
garypen merged 6 commits intoapollographql:devfrom
Conversation
cyberhck
reviewed
Jul 16, 2024
Add suggested change per PR comments Co-authored-by: Nishchal Gautam <cyberhck@users.noreply.github.com>
|
CI performance tests
|
BrynCooke
previously requested changes
Jul 22, 2024
Contributor
BrynCooke
left a comment
BrynCooke
left a comment
There was a problem hiding this comment.
Looks good but needs helm/chart/router/README.md updating.
garypen
reviewed
Jul 22, 2024
Comment on lines
+222
to
+229
| rollingUpdate: | ||
| {} | ||
| # Adjust rolling update strategy. Can take absolute values or % values. | ||
| # (https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment) | ||
| # Defaults if not set are: | ||
| # maxUnavailable: 25% | ||
| # maxSurge: 25% | ||
|
|
Contributor
There was a problem hiding this comment.
Would be nice to have line 224 moved to line 221 and specified as a helm-docs style comment
Contributor
Author
There was a problem hiding this comment.
I've adjusted and used helm-doc style comment per your feedback.
Contributor
Author
There was a problem hiding this comment.
@garypen - are you good with this PR now with the adjustment made?
Contributor
Author
There was a problem hiding this comment.
@garypen or @BrynCooke -- Sorry for the harassment, but can we get this merged in. I have at least one more PR I'd like to submit, but I'd like this one settled first before I do so.
Contributor
There was a problem hiding this comment.
@theJC Sorry about the delay, I've been on vacation.
BrynCooke
approved these changes
Aug 16, 2024
garypen
approved these changes
Aug 16, 2024
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le values
RollingUpdate maxSurge and maxUnavailable are commonly used deployment configuration values. This change makes their values able to be set via the router helm chart.
Fixes #5664
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩