Reintroduce "use spawn_blocking for parsing"#5644
Merged
Conversation
This reverts commit 31f90b2.
|
CI performance tests
|
Contributor
garypen
approved these changes
Jul 15, 2024
garypen
pushed a commit
that referenced
this pull request
Jul 15, 2024
Co-authored-by: Gary Pennington <gary@apollographql.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is ready to review once #5638 lands.
Re-lands #5582 after it was reverted in #5643 as it seems to have been causing tests to flake at a somewhat pronounced rate on
dev— always on Linux. We believe it's just actually the tests, or the way we tested, but we'll revert this for now sodevisn't flaking for everyone trying to develop against it.And worth mentioning again, this was was originally @xuorig's in #5235 which @Geal took over and @garypen ultimately landed in #5582 .
Marking this as a draft for someone to look at it.